Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

R4R: Fix linter errors #3138

Merged
merged 2 commits into from
Dec 17, 2018
Merged

R4R: Fix linter errors #3138

merged 2 commits into from
Dec 17, 2018

Conversation

cwgoes
Copy link
Contributor

@cwgoes cwgoes commented Dec 17, 2018

Temporary fix for #3126 (comment), but I think we should consider reverting the original PR in the future.

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

alexanderbez
alexanderbez approved these changes Dec 17, 2018
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@codecov
Copy link

codecov bot commented Dec 17, 2018 •
edited
Loading

Codecov Report

Merging #3138 into develop will increase coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #3138      +/-   ##
===========================================
+ Coverage    55.03%   55.06%   +0.02%     
===========================================
  Files          133      133              
  Lines         9435     9435              
===========================================
+ Hits          5193     5195       +2     
+ Misses        3925     3923       -2     
  Partials       317      317

@jackzampolin jackzampolin merged commit f10d790 into develop Dec 17, 2018
@jackzampolin jackzampolin deleted the cwgoes/fix-lint-error branch December 17, 2018 22:49
cwgoes added a commit that referenced this pull request Dec 19, 2018
@cwgoes
Fix linter errors (#3138)
b2c5ffe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackzampolin jackzampolin jackzampolin approved these changes

@alexanderbez alexanderbez alexanderbez approved these changes

@ebuchman ebuchman Awaiting requested review from ebuchman

@rigelrozanski rigelrozanski Awaiting requested review from rigelrozanski

Assignees
No one assigned
Labels
T:Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cwgoes @alexanderbez @jackzampolin