Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge GoS point release back to develop #3166

Merged
merged 6 commits into from
Dec 20, 2018
Merged

Merge GoS point release back to develop #3166

merged 6 commits into from
Dec 20, 2018

Conversation

cwgoes
Copy link
Contributor

@cwgoes cwgoes commented Dec 19, 2018

Release PR: #3165.


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

* Add boolean for LoadLatestVersion
* Update PENDING.md
@codecov
Copy link

codecov bot commented Dec 19, 2018

Codecov Report

Merging #3166 into develop will decrease coverage by 0.01%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #3166      +/-   ##
===========================================
- Coverage    55.03%   55.01%   -0.02%     
===========================================
  Files          133      133              
  Lines         9438     9435       -3     
===========================================
- Hits          5194     5191       -3     
- Misses        3924     3927       +3     
+ Partials       320      317       -3

@cwgoes
Copy link
Contributor Author

cwgoes commented Dec 19, 2018

Does GitHub really count approvals on the other PR for this branch as approvals for this PR?

That does not make much sense to me.

@jaekwon jaekwon merged commit 192ad58 into develop Dec 20, 2018
@cwgoes cwgoes deleted the cwgoes/gos-patch-1 branch December 20, 2018 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants