GoS point release #3165
Merged
GoS point release #3165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 86a214f.
Revert remove gov slashing
* Withdraw commission on self bond removal * Update PENDING.md
* Add boolean for LoadLatestVersion * Update PENDING.md
Codecov Report
@@ Coverage Diff @@
## master #3165 +/- ##
=========================================
- Coverage 55.05% 55% -0.06%
=========================================
Files 133 133
Lines 9430 9432 +2
=========================================
- Hits 5192 5188 -4
- Misses 3921 3927 +6
Partials 317 317 |
jackzampolin
approved these changes
Dec 19, 2018
|
Simulation passed. Please do a release |
zmanian
approved these changes
Dec 19, 2018
|
Needs more comments and tests but LGTM for now. We should comment and test more. |
| // before the validator is deleted (and the corresponding ValidatorDistInfo removed). | ||
| // If we change other parts of the code such that a self-delegation might remain after | ||
| // a validator is deleted, this logic will no longer be safe. | ||
| // TODO: Consider instead implementing this in a "BeforeValidatorRemoved" hook. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Point release for GoS fixes (which will be breaking, so
v0.29I suppose).This should see further review and simulation testing.
PR back to develop: #3166.
For Admin Use: