Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change default path to show swagger #5640

Merged
merged 4 commits into from
Feb 13, 2020
Merged

change default path to show swagger #5640

merged 4 commits into from
Feb 13, 2020

Conversation

jgimeno
Copy link
Contributor

@jgimeno jgimeno commented Feb 13, 2020

Closes: #5607

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@jgimeno
Copy link
Contributor Author

jgimeno commented Feb 13, 2020

Locally the unit test I created works, but not sure if, due to connecting to localhost in the CI environment it can work.

Any ideas on how to properly do it? Or if it is worth it? Thanks!!

@tac0turtle
Copy link
Member

tac0turtle commented Feb 13, 2020

AWESOME!! already getting into it.

client/lcd/root_test.go Outdated Show resolved Hide resolved
@tac0turtle
Copy link
Member

also a bit odd why the proto ci is failing..

@jgimeno
Copy link
Contributor Author

jgimeno commented Feb 13, 2020

Yeah I saw that, can be like a random failure that happens sometimes in CI? That can be solved with a re-execution?

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome -- great to see the contribution @jgimeno. Left some feedback on the test 👍

Also, we'll need a changelog entry under the Client Breaking Changes section.

client/lcd/root_test.go Outdated Show resolved Hide resolved
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 🌮

@alexanderbez alexanderbez merged commit 242f674 into cosmos:master Feb 13, 2020
@jgimeno jgimeno deleted the issue-5607 branch February 13, 2020 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add default endpoint for REST server
3 participants