ibc/03-connection: import export GenesisState #6067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
fedekunze
commented
Apr 24, 2020
| @@ -72,6 +83,12 @@ func (c ConnectionEnd) ValidateBasic() error { | |||
| return sdkerrors.Wrap(ibctypes.ErrInvalidVersion, "version can't be blank") | |||
| } | |||
| } | |||
| if c.ID == c.Counterparty.ConnectionID { | |||
There was a problem hiding this comment.
I added these 2 extra validations @cwgoes
There was a problem hiding this comment.
Why? It's fine if the identifiers are the same.
fedekunze
requested review from
alessio,
alexanderbez,
hschoenburg and
nylira
as code owners
Codecov Report
@@ Coverage Diff @@
## master #6067 +/- ##
==========================================
- Coverage 54.64% 54.35% -0.29%
==========================================
Files 426 430 +4
Lines 25890 26107 +217
==========================================
+ Hits 14148 14191 +43
- Misses 10763 10937 +174
Partials 979 979 |
cwgoes
suggested changes
Apr 24, 2020
| @@ -72,6 +83,12 @@ func (c ConnectionEnd) ValidateBasic() error { | |||
| return sdkerrors.Wrap(ibctypes.ErrInvalidVersion, "version can't be blank") | |||
| } | |||
| } | |||
| if c.ID == c.Counterparty.ConnectionID { | |||
There was a problem hiding this comment.
Why? It's fine if the identifiers are the same.
alexanderbez
approved these changes
Apr 24, 2020
…cosmos-sdk into fedekunze/import-export-ibc-pt-1
cwgoes
approved these changes
Apr 24, 2020
fedekunze
added
the
A:automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #5948
Description
For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)