Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: update globalfee.md #2330

Closed
2 of 9 tasks
yaruwangway opened this issue Mar 24, 2023 · 0 comments · Fixed by #2463
Closed
2 of 9 tasks

Docs: update globalfee.md #2330

yaruwangway opened this issue Mar 24, 2023 · 0 comments · Fixed by #2463
Assignees
Labels
scope: docs Improvements or additions to documentation

Comments

@yaruwangway
Copy link
Contributor

yaruwangway commented Mar 24, 2023

Summary

In globalfee.md, there are some illustration of submitting tx with fees, in case7 and 8, it is demonstrating bypass-msgs.

The followings in the doc need to be updated:

  • update test cases in globalfee.md
  • case 7 and 8, change gas -> maxTotalBypassMinFeeMsgGasUsage
  • change the bypass-msg in case 7 and 8 to ibc msgs.
  • demonstrate how maxTotalBypassMinFeeMsgGasUsage by submitting tx with multiple msgs.
  • mention maxTotalBypassMinFeeMsgGasUsage and bypass-msg-types are moved to params.
  • mention in checkTx state, fee antehandler checks the paid fees against combined Fees while in deliverTx state, checks paidfees against the globalfee ?
  • mention the bypass msgs in app.toml is deprecated. nodes inited by v10 will not have bypass msg in app.toml

Ref: #2316 (comment)

Problem Definition

Proposal


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
  • Is a spike necessary to map out how the issue should be approached?
@yaruwangway yaruwangway added type: feature-request New feature or request improvement status: waiting-triage This issue/PR has not yet been triaged by the team. labels Mar 24, 2023
@github-project-automation github-project-automation bot moved this to 🩹 Triage in Cosmos Hub Mar 24, 2023
@mpoke mpoke moved this from 🩹 Triage to 📥 Todo in Cosmos Hub Apr 2, 2023
@mpoke mpoke added scope: docs Improvements or additions to documentation and removed type: feature-request New feature or request improvement status: waiting-triage This issue/PR has not yet been triaged by the team. labels Apr 2, 2023
@sainoe sainoe self-assigned this Apr 20, 2023
@yaruwangway yaruwangway assigned yaruwangway and unassigned sainoe May 4, 2023
@yaruwangway yaruwangway moved this from 📥 Todo to 🩹 Triage in Cosmos Hub May 4, 2023
@yaruwangway yaruwangway moved this from 🩹 Triage to 🏗 In progress in Cosmos Hub May 11, 2023
@yaruwangway yaruwangway moved this from 🏗 In progress to 👀 In review in Cosmos Hub May 11, 2023
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Cosmos Hub Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: docs Improvements or additions to documentation
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

3 participants