Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: global fee params migration #2456

Closed
2 of 7 tasks
yaruwangway opened this issue May 3, 2023 · 1 comment
Closed
2 of 7 tasks

Test: global fee params migration #2456

yaruwangway opened this issue May 3, 2023 · 1 comment
Assignees
Labels
status: waiting-triage This issue/PR has not yet been triaged by the team. type: feature-request New feature or request improvement

Comments

@yaruwangway
Copy link
Contributor

yaruwangway commented May 3, 2023

Summary

The global fee and bypass-msgs are refactored. #2270
The global fee params are migrated to add two more params "bypass_min_fee_msg_types" and "max_total_bypass_minFee_msg_gas_usage".
Tests should be added to ensure the params are correctly migrated.

Problem Definition

Proposal

The following tests should be added:

  • unit test
  • local test
    run network with gaiad v9 -> propose 0.1uatom as global fee -> propose upgrade to v10 -> check the global fee params: global fee min gas should be 0.1 uatom, the bypass-msg and allowed bypass gas should be the default value.
gaiad q globalfee params
{
 "minimum_gas_prices": [],
 "bypass_min_fee_msg_types": [
   "/ibc.core.channel.v1.MsgRecvPacket",
   "/ibc.core.channel.v1.MsgAcknowledgement",
   "/ibc.core.client.v1.MsgUpdateClient",
   "/ibc.core.channel.v1.MsgTimeout",
   "/ibc.core.channel.v1.MsgTimeoutOnClose"
 ],
 "max_total_bypass_minFee_msg_gas_usage": "1000000"
}

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
  • Is a spike necessary to map out how the issue should be approached?
@yaruwangway yaruwangway added type: feature-request New feature or request improvement status: waiting-triage This issue/PR has not yet been triaged by the team. labels May 3, 2023
@github-project-automation github-project-automation bot moved this to 🩹 Triage in Cosmos Hub May 3, 2023
@yaruwangway yaruwangway changed the title Test: test global fee module after refactor Test: test global fee module refactor May 3, 2023
@yaruwangway yaruwangway changed the title Test: test global fee module refactor Test: global fee module refactor May 3, 2023
@yaruwangway yaruwangway changed the title Test: global fee module refactor Test: global fee params migration May 3, 2023
@sainoe
Copy link
Contributor

sainoe commented May 11, 2023

The tests are executed successfully after upgrading Gaia from v9.0.0 to this branch. The test shell scripts are located here atm as their location is TBD.

@yaruwangway yaruwangway moved this from 🩹 Triage to 🏗 In progress in Cosmos Hub May 11, 2023
@mpoke mpoke moved this from 🏗 In progress to 🛑 Blocked in Cosmos Hub May 11, 2023
@github-project-automation github-project-automation bot moved this from 🛑 Blocked to ✅ Done in Cosmos Hub May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting-triage This issue/PR has not yet been triaged by the team. type: feature-request New feature or request improvement
Projects
Status: ✅ Done
Development

No branches or pull requests

2 participants