Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gaia uses SDK general error types #2484

Closed
Tracked by #2413
mpoke opened this issue May 11, 2023 · 4 comments · Fixed by #2496
Closed
Tracked by #2413

Gaia uses SDK general error types #2484

mpoke opened this issue May 11, 2023 · 4 comments · Fixed by #2496
Assignees
Labels
type: tech-debt Slows down development in the long run

Comments

@mpoke
Copy link
Contributor

mpoke commented May 11, 2023

Problem

Gaia is currently using error types defined here. While this is fine for now, these error types may be deprecated in the future. The goal is for Gaia to define its own general errors. This would help with identifying if an error is from SDK or from Gaia.

See cosmos/ibc-go#3184 and cosmos/ibc-go#3186 as an example.

Closing criteria

Gaia doesn't use error types defined in github.com/cosmos/cosmos-sdk/types/errors.

@mpoke mpoke added the type: tech-debt Slows down development in the long run label May 11, 2023
@mpoke mpoke added this to Cosmos Hub May 11, 2023
@github-project-automation github-project-automation bot moved this to 🩹 Triage in Cosmos Hub May 11, 2023
@mpoke mpoke moved this from 🩹 Triage to 📥 Todo in Cosmos Hub May 11, 2023
@faddat
Copy link
Contributor

faddat commented May 13, 2023

Why would we do this?

This change would make the cosmos hub the only chain in cosmos that does not use the standard error types.

The errors in cosmos are standardized, precisely so that the chains match one another and development & debugging are easier.

Is there any indication that those error types will be deprecated?

I can understand why ibc-go is doing this, but i cannot understand why Gaia would diverge from standards in this way.

The basic is that I believe that this would create instead of relieving technical debt.

@mpoke
Copy link
Contributor Author

mpoke commented May 15, 2023

Why would we do this?

Is there any indication that those error types will be deprecated?

This is the recommendation of the SDK team. cc @tac0turtle

@ruthishvitwit
Copy link
Contributor

ruthishvitwit commented May 17, 2023

@mpoke Can i work on this issue??

@mpoke
Copy link
Contributor Author

mpoke commented May 17, 2023

@ruthishvitwit Sure. I assigned it to you. Thanks for contributing.

@mpoke mpoke moved this from 📥 Todo to 🏗 In progress in Cosmos Hub May 17, 2023
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Cosmos Hub Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: tech-debt Slows down development in the long run
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

3 participants