-
Notifications
You must be signed in to change notification settings - Fork 693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gaia uses SDK general error types #2484
Comments
Why would we do this? This change would make the cosmos hub the only chain in cosmos that does not use the standard error types. The errors in cosmos are standardized, precisely so that the chains match one another and development & debugging are easier. Is there any indication that those error types will be deprecated? I can understand why ibc-go is doing this, but i cannot understand why Gaia would diverge from standards in this way. The basic is that I believe that this would create instead of relieving technical debt. |
This is the recommendation of the SDK team. cc @tac0turtle |
@mpoke Can i work on this issue?? |
@ruthishvitwit Sure. I assigned it to you. Thanks for contributing. |
Problem
Gaia is currently using error types defined here. While this is fine for now, these error types may be deprecated in the future. The goal is for Gaia to define its own general errors. This would help with identifying if an error is from SDK or from Gaia.
See cosmos/ibc-go#3184 and cosmos/ibc-go#3186 as an example.
Closing criteria
Gaia doesn't use error types defined in
github.com/cosmos/cosmos-sdk/types/errors
.The text was updated successfully, but these errors were encountered: