Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps!: bump ICS to v2.4.0-lsm #2825

Merged
merged 3 commits into from
Nov 21, 2023
Merged

deps!: bump ICS to v2.4.0-lsm #2825

merged 3 commits into from
Nov 21, 2023

Conversation

mpoke
Copy link
Contributor

@mpoke mpoke commented Nov 21, 2023

Description

Closes: NA

Bump ICS to v2.4.0-lsm.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Included the correct type prefix in the PR title
  • Added ! to the type prefix if API, client, or state breaking change (i.e., requires minor or major version bump)
  • Targeted the correct branch (see PR Targeting)
  • Provided a link to the relevant issue or specification
  • Followed the guidelines for building SDK modules
  • Included the necessary unit and integration tests
  • Added a changelog entry in .changelog (for details, see contributing guidelines)
  • Included comments for documenting Go code
  • Updated the relevant documentation or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage

@mpoke mpoke merged commit b3b4c15 into main Nov 21, 2023
15 of 16 checks passed
@mpoke mpoke deleted the marius/bump-ics branch November 21, 2023 11:35
mergify bot pushed a commit that referenced this pull request Nov 21, 2023
* bump ICS to v2.4.0-lsm

* add changelog entries and update v14.0.0 section

* add changelog entry for #2821

(cherry picked from commit b3b4c15)
mpoke added a commit that referenced this pull request Nov 21, 2023
* bump ICS to v2.4.0-lsm

* add changelog entries and update v14.0.0 section

* add changelog entry for #2821

(cherry picked from commit b3b4c15)

Co-authored-by: Marius Poke <marius.poke@posteo.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants