Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(any): Add cosmos any type #115

Merged
merged 13 commits into from
Mar 20, 2024
Merged

chore(any): Add cosmos any type #115

merged 13 commits into from
Mar 20, 2024

Conversation

raynaudoe
Copy link
Collaborator

This PR removes the dependence on cosmos-sdk/codec/types
Partially closes cosmos/cosmos-sdk#19446

@raynaudoe raynaudoe changed the title Add cosmos any type chore(any): Add cosmos any type Mar 14, 2024
@raynaudoe raynaudoe marked this pull request as ready for review March 15, 2024 12:42
@raynaudoe raynaudoe requested a review from a team as a code owner March 15, 2024 12:42
julienrbrt
julienrbrt reviewed Mar 15, 2024
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just changelog for this addition and the go mod bump needed

go.mod Outdated Show resolved Hide resolved
types/any/any_with_cache_test.go Outdated Show resolved Hide resolved
@raynaudoe
Rename interface_registry
98bd04e 
Trim down interface_registry
tac0turtle
tac0turtle reviewed Mar 19, 2024
View reviewed changes
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, reverting the go mod change then it should be good

@raynaudoe
Copy link
Collaborator Author

looks good, reverting the go mod change then it should be good

ok, go bump reverted 👍🏻

@raynaudoe raynaudoe enabled auto-merge (squash) March 20, 2024 11:04
@raynaudoe raynaudoe merged commit 07294c8 into main Mar 20, 2024
3 checks passed
@raynaudoe raynaudoe deleted the eze/add_cosmos_any branch March 20, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kocubinski kocubinski kocubinski left review comments

@julienrbrt julienrbrt julienrbrt left review comments

@tac0turtle tac0turtle tac0turtle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature]: move codectypes.Any
4 participants
@raynaudoe @kocubinski @tac0turtle @julienrbrt