Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: memory leak in Import (backport #773) #774

Merged
merged 1 commit into from
May 19, 2023
Merged

fix: memory leak in Import (backport #773) #774

merged 1 commit into from
May 19, 2023

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented May 19, 2023

don't reference the children, which recursively retain the whole subtree in memory.

@yihuang
fix: memory leak in Import (backport cosmos#773)
74a9989 
don't reference the children, which recursively retain the whole subtree in memory.
@yihuang yihuang requested a review from a team as a code owner May 19, 2023 00:37
@yihuang yihuang mentioned this pull request May 19, 2023
Closed
@fedekunze
Copy link
Contributor

@tac0turtle @alexanderbez can you review this one too?

tac0turtle
tac0turtle approved these changes May 19, 2023
View reviewed changes
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@tac0turtle tac0turtle merged commit 94ab9b2 into cosmos:release/v0.19.x May 19, 2023
@yihuang yihuang deleted the memory-leak-backport branch May 19, 2023 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fedekunze fedekunze fedekunze approved these changes

@tac0turtle tac0turtle tac0turtle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yihuang @fedekunze @tac0turtle