Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: alliance information into README #4

Closed
wants to merge 1 commit into from
Closed

feat: alliance information into README #4

wants to merge 1 commit into from

Conversation

emidev98
Copy link
Contributor

This pull request includes Alliance module information into the List of Apps.

Related issues:

When merging or rejecting this PR both issues must also be closed

@jtieri
Copy link
Member

jtieri commented Apr 19, 2023

hey @emidev98 thanks for opening a PR! took a quick glance at alliance and this looks like it's more along the lines of a standard SDK module. I noticed there is no implementation of the IBCModule interface which to me is what makes something an IBC module. this repo is specifically for applications/modules/middleware that are built on top of IBC. I'm not sure that this is the right place for alliance but I could be convinced otherwise and would be curious to hear input from others.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants