Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

20-transfer: use a regex for denomination path parsing #30

Closed
cwgoes opened this issue Nov 12, 2020 · 1 comment
Closed

20-transfer: use a regex for denomination path parsing #30

cwgoes opened this issue Nov 12, 2020 · 1 comment

Comments

@cwgoes
Copy link
Contributor

cwgoes commented Nov 12, 2020

Determine whether this is actually clearer / more ergonomic than our current logic.
@colin-axner colin-axner transferred this issue from cosmos/cosmos-sdk Mar 4, 2021
faddat referenced this issue in notional-labs/ibc-go Feb 23, 2022
@ethanfrey
Merge pull request #30 from cosmwasm/vw/add-rest-server
8983d9b 
Added rest interface
faddat referenced this issue in notional-labs/ibc-go Mar 1, 2022
@jackzampolin
Merge PR #30: Refactor Config and codebase to use []Path and PathEnd
31943c8 
* Push up current work

* fix gas not set issue

* Fix parsing issue

* Complete refactor
@crodriguezvega
Copy link
Contributor

Closing since we recently decided to not use regex for string parsing. We will keep using strings.Split instead.

CosmosCar pushed a commit to caelus-labs/ibc-go that referenced this issue Nov 6, 2023
@tzdybal
Merge pull request cosmos#30 from lazyledger/tzdybal/p2p/refactor_tests
2ec85bb 
Refactoring of P2P unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@crodriguezvega @cwgoes