Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add ibc module events after calling back the OnRecvPacket method of the ibc module #4871

Closed
wants to merge 1 commit into from

Conversation

dreamer-zq
Copy link

…ule's events are lost.

Description

Because when ibc executes the OnRecvPacket callback function of the module, the ctx used is cacheCtx. As a result, the events of the final module are not added to the global ctx and the events of the module are lost.

closes: #XXXX

Commit Message / Changelog Entry

type: commit message

see the guidelines for commit messages. (view raw markdown for examples)


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

@crodriguezvega
Copy link
Contributor

crodriguezvega commented Oct 16, 2023

Thank you for your PR, @dreamer-zq. Unfortunately, we had to remove this code when we patched the Huckleberry vulnerability. We are investigating some alternatives to emit the error in the events (this issue in the SDK is relevant), but the error should be in the logs still, in case you can use that for the time being.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants