fix(ibc-clients/tendermint): disallow empty proof-specs and empty depth range in proof-specs #1104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @gr4yha7 ! Can you please add some unit tests to the new |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1104 +/- ##
==========================================
+ Coverage 66.52% 66.56% +0.04%
==========================================
Files 208 208
Lines 20705 20733 +28
==========================================
+ Hits 13773 13801 +28
Misses 6932 6932 ☔ View full report in Codecov by Sentry. |
rnbguy
reviewed
Feb 29, 2024
rnbguy
changed the title
Farhad-Shabani
requested changes
Feb 29, 2024
There was a problem hiding this comment.
You may have noticed, just highlighting that there's an implicit check as part of ICS23 here. Though, I'm still in favor of adding an explicit check in ibc-rs to prevent the creation of faulty clients.
All good, thank you both. Just requested a small fix!
|
Thanks @gr4yha7 🙏 nice work ✨ |
Farhad-Shabani
pushed a commit
that referenced
this pull request
Sep 9, 2024
…th range in proof-specs (#1104) * fix: disallow empty proof-specs and empty depth range in proof-specs * chore: add changelog entry * nits * test: add unit test * chore: use default option (none) * avoid new var * nit in changelog * rm redundant clone * propagate errors * proof depth is unsigned * use impl method --------- Co-authored-by: Ranadeep Biswas <mail@rnbguy.at> Co-authored-by: Rano | Ranadeep <ranadeep@informal.systems>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1100
PR author checklist:
unclog.docs/).Reviewer checklist:
Files changedin the GitHub PR explorer.