feat(ibc-query): define request/response domain types #1129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1129 +/- ##
==========================================
- Coverage 66.50% 63.11% -3.40%
==========================================
Files 209 217 +8
Lines 20692 21806 +1114
==========================================
Hits 13762 13762
- Misses 6930 8044 +1114 ☔ View full report in Codecov by Sentry. |
rnbguy
requested changes
Mar 18, 2024
Signed-off-by: Rano | Ranadeep <ranadip.bswas@gmail.com>
rnbguy
approved these changes
Mar 18, 2024
|
|
rnbguy
changed the title
Merged
3 tasks
Farhad-Shabani
added a commit
that referenced
this pull request
Sep 9, 2024
* feat: Add domain definitions for request/response query types in ibc-query * chore: add unclog * feat: define serde & schema features * fix: derive missing schemars * docs: add remarks to README + additional unclog * chore: some clean-ups * chore: organize orders * feat: add TryFrom for response types * use invalid_argument error code * rm redudant lint relaxing * use proof_not_found method * consistent QueryError enum structure * Update ibc-query/README.md Signed-off-by: Rano | Ranadeep <ranadip.bswas@gmail.com> * clippy::match_bool * clippy::use_self * clippy::or_fun_call * use if-let-some over match * clippy::redundant_closure_for_method_calls * Into::into over T::from * clippy::uninlined_format_args * clippy::cast_lossless * clippy::impl_trait_in_params * clippy::shadow_reuse * clippy::pattern_type_mismatch * safe use of u64::MAX * then over then_some * rename IntoProto to IntoResponse --------- Signed-off-by: Rano | Ranadeep <ranadip.bswas@gmail.com> Co-authored-by: Ranadeep Biswas <mail@rnbguy.at> Co-authored-by: Rano | Ranadeep <ranadeep@informal.systems>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1128
PR author checklist:
unclog.docs/).Reviewer checklist:
Files changedin the GitHub PR explorer.