Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: generalize ibc-testkit types to allow remote storage and light clients #1270

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

rnbguy
Copy link
Collaborator

@rnbguy rnbguy commented Jun 28, 2024

Closes: #1269

Description


PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests.
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

Copy link

codecov bot commented Jun 28, 2024

Codecov Report

Attention: Patch coverage is 97.14286% with 6 lines in your changes missing coverage. Please review.

Project coverage is 67.49%. Comparing base (7ff41b3) to head (9236182).

Files Patch % Lines
ibc-testkit/src/relayer/context.rs 86.20% 4 Missing ⚠️
ibc-testkit/src/testapp/ibc/core/types.rs 71.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1270      +/-   ##
==========================================
+ Coverage   67.42%   67.49%   +0.06%     
==========================================
  Files         235      235              
  Lines       23811    23883      +72     
==========================================
+ Hits        16055    16120      +65     
- Misses       7756     7763       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rnbguy rnbguy force-pushed the rano/feat/generialize-mockibcstore branch from 13c18ea to 94dc0bc Compare June 28, 2024 13:45
@rnbguy rnbguy force-pushed the rano/feat/generialize-mockibcstore branch from 94dc0bc to e483d9f Compare June 28, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve the usability of ibc-testkit as a remote crate
1 participant