imp: refactor send-coins-*() and add memo field to escrow-* and burn-* methods
#836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and introduce extra data
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #836 +/- ##
==========================================
- Coverage 70.86% 70.69% -0.18%
==========================================
Files 178 178
Lines 17869 17919 +50
==========================================
+ Hits 12663 12667 +4
- Misses 5206 5252 +46 ☔ View full report in Codecov by Sentry. |
* fix: restore no_std support for serde feature * deps: bump ibc-proto-rs to v0.34.0 * fix: reflect changes b/c of ibc-proto-rs * imp: comply naming + use better domain type for host_consensus_state * fix: apply host_cons_state_proof changes for conn_open_ack * fix: use domain TmEvent instead of proto for upgrade client proposal handler * misc: add a unclog for ibc-proto-rs upgrade
* bump ibc-proto and borsh * changelog
Fix is in implementing it properly for our `Timestamp`
7 tasks
Farhad-Shabani
changed the title
send-coins-*() method and add memo field to escrow-coins-*()
Farhad-Shabani
changed the title
send-coins-*() method and add memo field to escrow-coins-*()send-coins-*() and add memo field to escrow-* and burn-* methods
Farhad-Shabani
approved these changes
Dec 11, 2023
Farhad-Shabani
added a commit
that referenced
this pull request
Sep 9, 2024
… `burn-*` methods (#836) * split send_coins_*() functions and introduce extra data * arg name change * add error variant * add error * add `Other` variant to `TokenTransferError` * fmt * fix: restore `no_std` support for `serde` feature (#790) * fix: restore no_std support for serde feature * deps: bump ibc-proto-rs to v0.34.0 * fix: reflect changes b/c of ibc-proto-rs * imp: comply naming + use better domain type for host_consensus_state * fix: apply host_cons_state_proof changes for conn_open_ack * fix: use domain TmEvent instead of proto for upgrade client proposal handler * misc: add a unclog for ibc-proto-rs upgrade * bump ibc-proto to v0.34.1 and borsh to v0.10 (#844) * bump ibc-proto and borsh * changelog * add borsh derive for `MsgTransfer` * derive JsonSchema for MsgTransfer * fix JsonSchema derive for MsgTransfer Fix is in implementing it properly for our `Timestamp` * execute() methods must have &mut self * nit: spell checker * imp: simplify escrow/unescrow abstraction + using memo instead * chore: dress up with unclogs * nit: adjust unlogs * nit: remove confusing InternalTransferFailed error variant * imp: add memo field to burn-coins-* * docs: adjust & add missing docstrings --------- Co-authored-by: Farhad Shabani <Farhad.Shabani@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #837
Closes: #839
Closes: #985
Integration tests: informalsystems/basecoin-rs#130