Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICS 4: Channel & Packet Semantics #34

Merged
merged 81 commits into from
Jun 8, 2019
Merged

ICS 4: Channel & Packet Semantics #34

merged 81 commits into from
Jun 8, 2019

Conversation

cwgoes
Copy link
Contributor

@cwgoes cwgoes commented Mar 7, 2019 •
edited
Loading

Closes #1.
Closes #109.

Starting from old spec.

@cwgoes cwgoes added tao Transport, authentication, & ordering layer. wip Issues or pull requests which are in progress. labels Mar 7, 2019
@cwgoes cwgoes changed the title WIP: ICS 4 - Channel Semantics ICS 4: Channel Semantics Mar 7, 2019
@cwgoes cwgoes mentioned this pull request Mar 18, 2019
Closed
ebuchman
ebuchman reviewed Mar 26, 2019
View reviewed changes
spec/ics-4-channel-semantics/README.md Outdated Show resolved Hide resolved
spec/ics-4-channel-semantics/README.md Outdated Show resolved Hide resolved
spec/ics-4-channel-semantics/README.md Outdated Show resolved Hide resolved
@cwgoes
Copy link
Contributor Author

cwgoes commented Mar 31, 2019

(not yet ready-for-review; I am going to rewrite most of this specification once #32 is reviewed / merged)

@cwgoes
Copy link
Contributor Author

cwgoes commented May 9, 2019

Ref #73 (comment)

@cwgoes cwgoes changed the title ICS 4: Channel Semantics ICS 4: Channel & Packet Semantics May 10, 2019
@cwgoes
Copy link
Contributor Author

cwgoes commented May 11, 2019 •
edited
Loading

Please reformat re: #84

edit: Done.

@cwgoes
Copy link
Contributor Author

cwgoes commented Jun 5, 2019

Can you add more detail on how the packet sequence is used?

Added descriptions of all fiends in the ChannelEnd and Packet data structures.

@cwgoes cwgoes mentioned this pull request Jun 5, 2019
Closed
@cwgoes
Copy link
Contributor Author

cwgoes commented Jun 5, 2019 •
edited
Loading

  • Sanity check pseudocode

@cwgoes
Copy link
Contributor Author

cwgoes commented Jun 5, 2019

Ref #113

@cwgoes
Copy link
Contributor Author

cwgoes commented Jun 7, 2019

... still working on that diagram but pseudocode has been cleaned up and many explanations added.

@cwgoes cwgoes mentioned this pull request Jun 8, 2019
Closed
@cwgoes
Copy link
Contributor Author

cwgoes commented Jun 8, 2019

Merging prior to IBC workshop, further comments always welcome.

@cwgoes cwgoes merged commit b8e9826 into master Jun 8, 2019
@cwgoes cwgoes deleted the cwgoes/ics-4-channel-semantics branch June 8, 2019 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebuchman ebuchman ebuchman left review comments

@ancazamfir ancazamfir ancazamfir left review comments

@liamsi liamsi liamsi left review comments

@jaekwon jaekwon Awaiting requested review from jaekwon

@sunnya97 sunnya97 Awaiting requested review from sunnya97

Assignees
No one assigned
Labels
ready-for-review Pull requests which are ready for review. tao Transport, authentication, & ordering layer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IBC dataflow cross-section diagram ICS 4: Channel & Packet Semantics
4 participants
@cwgoes @ancazamfir @ebuchman @liamsi