Metadata Negotiation in ICS27 #642
Conversation
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
| @@ -162,7 +162,7 @@ This port will be used to create channels between the controller & host chain fo | |||
| 2. The controller chain emits an event signaling to open a new channel on this port given a connection. | |||
| 3. A relayer listening for `ChannelOpenInit` events will continue the channel creation handshake. | |||
| 4. During the `OnChanOpenTry` callback on the host chain an interchain account will be registered and a mapping of the interchain account address to the owner account address will be stored in state (this is used for authenticating transactions on the host chain at execution time). | |||
| 5. During the `OnChanOpenAck` callback on the controller chain a record of the interchain account address registered on the host chain during `OnChanOpenTry` is set in state with a mapping from portID -> interchain account address. See [version negotiation](#Version-negotiation) section below for how to implement this. | |||
| 5. During the `OnChanOpenAck` callback on the controller chain a record of the interchain account address registered on the host chain during `OnChanOpenTry` is set in state with a mapping from portID -> interchain account address. See [metadata negotiation](#Metadata-negotiation) section below for how to implement this. | |||
There was a problem hiding this comment.
@colin-axner Did we say that we needed to update this mapping to include connection seq?
There was a problem hiding this comment.
The portID is unique from the perspective of the controller chain, so no the connection seq is not needed
There was a problem hiding this comment.
Great improvements 🤝
Would it be worth adding this check in this PR as well? I can also do a small follow-up.
Co-authored-by: Damian Nolan <damiannolan@gmail.com>
| @@ -317,21 +381,37 @@ function onChanOpenTry( | |||
| channelIdentifier: Identifier, | |||
| counterpartyPortIdentifier: Identifier, | |||
| counterpartyChannelIdentifier: Identifier, | |||
| version: string, | |||
| counterpartyVersion: string) { | |||
| counterpartyVersion: string) (version: string) { | |||
There was a problem hiding this comment.
This is not consistent with the definition of onChanOpenTry in ICS-26. However, it is consistent with the ibc-go implementation. Could you also modify ICS-26 in this PR or should we open an issue?
There was a problem hiding this comment.
Yes we should create a new issue to update ICS26
There was a problem hiding this comment.
There was a problem hiding this comment.
Yeah, it was modified by #629. I was looking at an older branch. We really need to add some release tags to the IBC specs and separate IBC apps from IBC core. It will become very difficult to keep track of all these changes to IBC core (some of them quite relevant) while writing spec for apps.
Co-authored-by: Marius Poke <marius.poke@posteo.de>
Pull Metadata negotiation logic out of #638