Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing signers in proto message #2095

Merged
merged 4 commits into from
Jul 25, 2024
Merged

fix: add missing signers in proto message #2095

merged 4 commits into from
Jul 25, 2024

Conversation

sainoe
Copy link
Contributor

@sainoe sainoe commented Jul 25, 2024

Add signer fields missing in the provider's message proto definition.

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Included the correct type prefix in the PR title
  • Added ! to the type prefix if the change is state-machine breaking
  • Confirmed this PR does not introduce changes requiring state migrations, OR migration code has been added to consumer and/or provider modules
  • Targeted the correct branch (see PR Targeting)
  • Provided a link to the relevant issue or specification
  • Followed the guidelines for building SDK modules
  • Included the necessary unit and integration tests
  • Added a changelog entry to CHANGELOG.md
  • Included comments for documenting Go code
  • Updated the relevant documentation or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed
  • If this PR is library API breaking, bump the go.mod version string of the repo, and follow through on a new major release

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! the type prefix if the change is state-machine breaking
  • confirmed this PR does not introduce changes requiring state migrations, OR confirmed migration code has been added to consumer and/or provider modules
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage

@sainoe sainoe requested a review from a team as a code owner July 25, 2024 14:25
Copy link
Contributor

coderabbitai bot commented Jul 25, 2024

Warning

Rate limit exceeded

@sainoe has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 0 minutes and 45 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between 9a39ebf and 499741f.

Walkthrough

Walkthrough

The recent changes enhance the MsgSetConsumerCommissionRate and MsgConsumerModification messages by introducing a signer field and a corresponding option for specifying the transaction signer. This improvement provides clearer accountability and security measures for transaction validation, ensuring that the entities responsible for signing transactions are explicitly defined within the message structure.

Changes

File Summary Change Summary
proto/interchain_security/ccv/provider/v1/tx.proto Updated MsgSetConsumerCommissionRate to include option (cosmos.msg.v1.signer) = "signer"; and added string signer = 4 [(cosmos_proto.scalar) = "cosmos.AddressString"];. Updated MsgConsumerModification to include option (cosmos.msg.v1.signer) = "authority";.

Sequence Diagram(s)

sequenceDiagram
    participant Consumer
    participant Validator
    participant Blockchain

    Consumer->>Validator: Propose commission rate change (with signer)
    Validator->>Blockchain: Validate proposal with signer info
    Blockchain-->>Validator: Confirmation of validity
    Validator-->>Consumer: Acknowledgment of proposal submission
Loading

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the C:x/provider Assigned automatically by the PR labeler label Jul 25, 2024
@MSalopek MSalopek added this pull request to the merge queue Jul 25, 2024
Merged via the queue into main with commit aedc0c8 Jul 25, 2024
15 checks passed
@MSalopek MSalopek deleted the sainoe/msg-fixes branch July 25, 2024 16:34
mergify bot pushed a commit that referenced this pull request Jul 25, 2024
* add missing signers in msgs

* add changelog entries

* nit

(cherry picked from commit aedc0c8)
sainoe added a commit that referenced this pull request Jul 26, 2024
fix: add missing signers in proto message (#2095)

* add missing signers in msgs

* add changelog entries

* nit

(cherry picked from commit aedc0c8)

Co-authored-by: Simon Noetzlin <simon.ntz@gmail.com>
@coderabbitai coderabbitai bot mentioned this pull request Jul 26, 2024
12 tasks
@coderabbitai coderabbitai bot mentioned this pull request Aug 6, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:backport/v5.1.x C:x/provider Assigned automatically by the PR labeler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants