Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix signer in the commission rate message (backport #2107) #2109

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jul 29, 2024

Description

Issuing a MsgSetConsumerCommissionRate message was giving us back:

gaiad tx provider set-consumer-commission-rate pion-1 0.15 --from apple --gas auto --gas-adjustment 2 --gas-prices 0.005uatom -y
Error: rpc error: code = Unknown desc = rpc error: code = Unknown desc = no cosmos.msg.v1.signer option found for message interchain_security.ccv.provider.v1.MsgSetConsumerCommissionRate;

We added the signer but we still received that the address is missing.

This PR fixes this issue by setting the Signer field in the message. After this PR changes, when we issue a
MsgSetConsumerCommissionRate against a local gaiad node we get:

failed to execute message; message index: 0: unknown consumer chain, with id: chain-1: no consumer chain with this chain id'

which means the message got parsed correctly and was about to be handled.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Included the correct type prefix in the PR title
  • Added ! to the type prefix if the change is state-machine breaking
  • Confirmed this PR does not introduce changes requiring state migrations, OR migration code has been added to consumer and/or provider modules
  • Targeted the correct branch (see PR Targeting)
  • Provided a link to the relevant issue or specification
  • Followed the guidelines for building SDK modules
  • Included the necessary unit and integration tests
  • Added a changelog entry to CHANGELOG.md
  • Included comments for documenting Go code
  • Updated the relevant documentation or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed
  • If this PR is library API breaking, bump the go.mod version string of the repo, and follow through on a new major release

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! the type prefix if the change is state-machine breaking
  • confirmed this PR does not introduce changes requiring state migrations, OR confirmed migration code has been added to consumer and/or provider modules
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage

Summary by CodeRabbit

  • New Features

    • Enhanced transaction validation by including a signer address in the consumer commission rate message creation.
  • Bug Fixes

    • Minor structural adjustment to the message definition for improved clarity, with no impact on functionality.

This is an automatic backport of pull request #2107 done by [Mergify](https://mergify.com).

@mergify mergify bot requested a review from a team as a code owner July 29, 2024 11:35
@github-actions github-actions bot added the C:x/provider Assigned automatically by the PR labeler label Jul 29, 2024
@sainoe sainoe merged commit 80a4b7d into release/v5.1.x Jul 29, 2024
15 checks passed
@sainoe sainoe deleted the mergify/bp/release/v5.1.x/pr-2107 branch July 29, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:x/provider Assigned automatically by the PR labeler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants