-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move e2e tests to independent folder #297
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @smarshall-spitzbart. I didn't check the functionality, since I guess it's just a refactoring, right?
At the moment the structure is a bit hard to follow, maybe a README.md would help, i.e.,
setup_test.go
-- setup for the e2e testscommon_test.go
-- helper functionschannel_init_test.go
-- e2e tests for the Channel Initialization sub-protocolvalset_update_test.go
-- e2e tests for the Validator Set Update sub-protocolunbonding_test.go
-- e2e tests for the Completion of Unbonding Operationsslashing_test.go
-- e2e tests for the Consumer Initiated Slashing sub-protocoldistribution_test.go
-- e2e tests for the Reward Distribution sub-protocolstop_consumer_test.go
-- e2e tests for the Consumer Chain Removal sub-protocol
Move to valset_update.go
the content from bonding_test.go
and vsc_test.go
.
Move to channel_init_test.go
the content from genesis_test.go
, ibc_test.go
, history_test.go
, proposal_test.go
.
distribution_test.go
will be empty for now.
Re. the 4 different ...TestSuite
s data structure, I think we can have only one, but let's do that in a separate PR.
Co-authored-by: Marius Poke <marius.poke@posteo.de>
You're correct that I didn't change any test functionality in this PR, I only moved things around. Your mentioned file organization sounds great to me, thank you! My only correction to your proposed solution is that I believe Lastly I've opened #300 to address the fact that we have a lot of redundant code in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work.
Closes #219