Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate e2e test setup for democracy consumer #381

Merged
merged 8 commits into from
Oct 13, 2022
Merged

Remove duplicate e2e test setup for democracy consumer #381

merged 8 commits into from
Oct 13, 2022

Conversation

shaspitz
Copy link
Contributor

@shaspitz shaspitz commented Oct 6, 2022 •
edited
Loading

Removes unneeded setup code for democracy consumer e2e tests.

@shaspitz shaspitz mentioned this pull request Oct 6, 2022
Closed
sainoe
sainoe approved these changes Oct 10, 2022
View reviewed changes
Copy link
Contributor

@sainoe sainoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Having ConsumerDemocracyTestSuite composed of two test suites is a bit confusing but it's worths it to remove these big duplicates imo.

@shaspitz
Copy link
Contributor Author

shaspitz commented Oct 11, 2022 •
edited
Loading

Nice work! Having ConsumerDemocracyTestSuite composed of two test suites is a bit confusing but it's worths it to remove these big duplicates imo.

Agreed that my first implementation was a bit confusing (using suite and underlyingSuite.. the term "suite" is overloaded already lol), turns out the setup code for democracy consumer was completely unneeded. So this PR only removes dead setup code

mpoke
mpoke approved these changes Oct 13, 2022
View reviewed changes
Copy link
Contributor

@mpoke mpoke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mpoke mpoke merged commit 2766b1c into main Oct 13, 2022
@mpoke mpoke deleted the remove-dup-setup branch October 13, 2022 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sainoe sainoe sainoe approved these changes

@mpoke mpoke mpoke approved these changes

@jtremback jtremback Awaiting requested review from jtremback

@danwt danwt Awaiting requested review from danwt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shaspitz @mpoke @sainoe