Add staking module integration tests #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o prathyusha/staking_module
…o prathyusha/staking_module
PrathyushaLakkireddy
changed the title
anilcse
changed the title
anilcse
reviewed
Jun 22, 2022
13 tasks
anilcse
reviewed
Jul 12, 2022
…o prathyusha/staking_module
anilcse
requested changes
Jul 18, 2022
anilcse
reviewed
Jul 18, 2022
internal/modules/staking/test.py
Outdated
Comment on lines
32
to
36
| if sender == validator: | ||
| sys.exit( | ||
| 'Error: The values of arguments "sender" and "receiver" are equal make sure to set different values' | ||
| ) | ||
|
|
There was a problem hiding this comment.
this canot be true as there will be different prefixes
Suggested change
| if sender == validator: | |
| sys.exit( | |
| 'Error: The values of arguments "sender" and "receiver" are equal make sure to set different values' | |
| ) |
internal/modules/staking/test.py
Outdated
Comment on lines
32
to
36
| if sender == validator: | ||
| sys.exit( | ||
| 'Error: The values of arguments "sender" and "receiver" are equal make sure to set different values' | ||
| ) | ||
|
|
There was a problem hiding this comment.
this canot be true as there will be different prefixes
Suggested change
| if sender == validator: | |
| sys.exit( | |
| 'Error: The values of arguments "sender" and "receiver" are equal make sure to set different values' | |
| ) |
internal/modules/staking/test.py
Outdated
Comment on lines
29
to
30
| # assign the arguments | ||
| sender, amount_to_be_sent = delegator, 5 |
There was a problem hiding this comment.
Suggested change
| # assign the arguments | |
| sender, amount_to_be_sent = delegator, 5 | |
| # assign the arguments | |
| amount = 5 |
anilcse
reviewed
Jul 18, 2022
anilcse
approved these changes
Jul 18, 2022
anilcse
reviewed
Jul 18, 2022
anilcse
reviewed
Jul 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #20
This PR adds all the txs and query integration tests for x/staking module