Skip to content
This repository has been archived by the owner on Oct 27, 2020. It is now read-only.

Update Period is set as Trusting Period #7

Closed
cmwaters opened this issue Jan 24, 2020 · 4 comments
Closed

Update Period is set as Trusting Period #7

cmwaters opened this issue Jan 24, 2020 · 4 comments

Comments

@cmwaters
Copy link

updatePeriod is never used

var (
	lcMap map[string]*lite.Client // chainID => client

	trustedHash    []byte
	trustedHeight  int64
	trustingPeriod time.Duration
	updatePeriod   time.Duration
	url            string
)

Instead the update period for the lite client is set as lite.UpdatePeriod(c.TrustOptions.Get().Period)) where the trusted period is set here:

if trustingPeriod > 0 {
	chain.TrustOptions.Period = trustingPeriod.String()
}
@melekes
Copy link
Contributor

melekes commented Jan 27, 2020

Update period should be a config option imho.

@cmwaters
Copy link
Author

" Update period should be a config option imho."
As in an option in the command line or one set in the config file?

@melekes
Copy link
Contributor

melekes commented Jan 27, 2020

config file

reset cmd will have a update-period flag, but we don't have to implement that now

@cmwaters
Copy link
Author

Okay, I will add that in

jackzampolin pushed a commit that referenced this issue Mar 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants