recv_packet/write_acknowledgement separation #1038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… be in separate blocks with forward middleware
agouin
changed the title
agouin
requested review from
jackzampolin,
jtieri,
boojamya and
mark-rushakoff
as code owners
jtieri
approved these changes
Nov 8, 2022
Comment on lines
-55
to
-78
| switch event.Type { | ||
| case chantypes.EventTypeRecvPacket, chantypes.EventTypeWriteAck: | ||
| pi := &packetInfo{Height: height} | ||
| pi.parseAttrs(log, evt.Attributes) | ||
| ck, err := processor.PacketInfoChannelKey(event.Type, provider.PacketInfo(*pi)) | ||
| if err == nil { | ||
| pk := packetKey{ | ||
| sequence: pi.Sequence, | ||
| channel: ck, | ||
| } | ||
| _, ok := recvPacketMsgs[pk] | ||
| if !ok { | ||
| recvPacketMsgs[pk] = pi | ||
| } else { | ||
| recvPacketMsgs[pk].parseAttrs(log, evt.Attributes) | ||
| } | ||
| } | ||
| default: | ||
| m := parseIBCMessageFromEvent(log, evt, chainID, height) | ||
| if m == nil || m.info == nil { | ||
| // Not an IBC message, don't need to log here | ||
| continue | ||
| } | ||
| messages = append(messages, *m) |
agouin
added a commit
that referenced
this pull request
Nov 9, 2022
* Separate recv_packet from write_acknowledgement events since they can be in separate blocks with forward middleware * update recv packet info in map * Correlate for flushes * Remove unnecessary change * Fix acks query
agouin
added a commit
that referenced
this pull request
Nov 15, 2022
* Separate recv_packet from write_acknowledgement events since they can be in separate blocks with forward middleware * update recv packet info in map * Correlate for flushes * Remove unnecessary change * Fix acks query
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separate
recv_packetfromwrite_acknowledgementevents since they can be in separate blocks with forward middleware.This moves the duty of combining the data from the
write_acknowledgementevent with therecv_packetevent into the path processor, which simplifies the event parser.