[fix] Ordered channel closure packet queue #1050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow sending timeout on close packets when the channel is closed Remove retention immediately when a packet is attempted to be sent on a closed channel
…dshakes over packet messages
agouin
requested review from
jackzampolin,
jtieri,
boojamya and
mark-rushakoff
as code owners
jtieri
reviewed
Dec 5, 2022
agouin
added a commit
that referenced
this pull request
Dec 12, 2022
* Fix timeout on close handling Allow sending timeout on close packets when the channel is closed Remove retention immediately when a packet is attempted to be sent on a closed channel * Prioritize handshake messages * prioritize connection handshakes over channel handshakes, and all handshakes over packet messages * sequence handling should span all event types for packets in a given direction * fix connection open try retention clear bug * Fix track processing * Pipe in LDFLAGS env var to enable fully static bin * move helper out to method * update stale comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an ordered channel is closed, all queued packets should be a noop.
This removes retention immediately when a packet is attempted to be sent on a closed channel.
Additionally, this groups messages of all event types for sorting by sequence for ordered channels. Only the lowest sequence should be handled, regardless of event type.