fix memory leak & uninitialized var #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 22, 2016 19:07
[themis/tests/themis/themis_seccure_message.c:53]: (error) Uninitialized variable: res
[tests/themis/themis_seccure_message.c:105]: (error) Memory leak: unwrapped_message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On line no. 53 of 'themis_seccure_message.c' the variable '
themis_status_t' is uninitialized. It's always good to initialize variables, because if you try to retrieve a value before it gets assigned any actual (non-garbage) value, then it results in undefined behavior.On line no. 105 of 'themis_seccure_message.c' there is a memory leak, which is a non-security bug.
Found by https://github.com/bryongloden/cppcheck