Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use media_subpath for media embed #1745

Merged
merged 3 commits into from
May 18, 2024
Merged

Use media_subpath for media embed #1745

merged 3 commits into from
May 18, 2024

Conversation

kungfux
Copy link
Collaborator

@kungfux kungfux commented May 13, 2024

Type of change

  • Improvement (refactoring and improving code)

Description

Embedded video does not respect the media_subpath Front Matter variable #1738.

Root cause: #1618 (actually postponed due to possible issues fixed in #1672).
Since cache issue is fixed, it should be safe to use media_subpath for all media types now as it was discussed previously.

Additional context

Fixes #1738

@kungfux kungfux requested a review from MrMurdock11 May 13, 2024 21:53
cotes2020
cotes2020 reviewed May 14, 2024
View reviewed changes
Copy link
Owner

@cotes2020 cotes2020 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the type should be fix in commit message. Also, to make it easier to manage commits, from now on perf will only be used for performance improvements. For other improvements, consider using the feat, fix or refactor types.

@cotes2020 cotes2020 changed the base branch from master to hotfix/7.0.1 May 14, 2024 04:54
@cotes2020 cotes2020 merged commit 00a27a1 into cotes2020:hotfix/7.0.1 May 18, 2024
5 checks passed
github-actions bot pushed a commit that referenced this pull request May 18, 2024
@semantic-release-bot
chore(release): 7.0.1
20987f2 
## [7.0.1](v7.0.0...v7.0.1) (2024-05-18)

### Bug Fixes

* **analytics:** goatcounter pv greater than 1K cannot be converted to numbers ([#1762](#1762)) ([33a1fa7](33a1fa7))
* audio/video path apply variable `media_subpath` ([#1745](#1745)) ([00a27a1](00a27a1))
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 7.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@kungfux kungfux deleted the perf/use-media-subpath-for-media-embed branch May 18, 2024 17:51
lotusk08 added a commit to lotusk08/lotusk08.github.io that referenced this pull request May 25, 2024
@lotusk08
Squashed commit of the following:
5dd39f3 
commit 079d1a1
Author: Steve Hoang <82992510+lotusk08@users.noreply.github.com>
Date:   Fri May 24 18:23:01 2024 +0700

    chore: update some text

commit 54de54c
Author: Steve Hoang <82992510+lotusk08@users.noreply.github.com>
Date:   Sat May 18 21:18:32 2024 +0700

    chore(color): comment system primary color button

commit e523ce4
Author: Steve Hoang <82992510+lotusk08@users.noreply.github.com>
Date:   Sat May 18 21:09:02 2024 +0700

    buid(js): update compile

commit 112ded8
Merge: 358170e 0102aba
Author: Steve Hoang <82992510+lotusk08@users.noreply.github.com>
Date:   Sat May 18 20:53:57 2024 +0700

    Merge remote-tracking branch 'upstream/master'

commit 358170e
Author: Steve Hoang <82992510+lotusk08@users.noreply.github.com>
Date:   Sat May 18 20:48:32 2024 +0700

    Update waline.html

commit 39a8fd2
Author: Steve Hoang <82992510+lotusk08@users.noreply.github.com>
Date:   Sat May 18 20:48:22 2024 +0700

    refactor(ui): 404 page

commit 0102aba
Author: Jason <50330957+itsjason-net@users.noreply.github.com>
Date:   Sat May 18 06:05:09 2024 -0500

    feat: add Bluesky social links (cotes2020#1759)

commit 6cb1a5a
Merge: 90a4cc7 20987f2
Author: semantic-release-bot <semantic-release-bot@martynus.net>
Date:   Sat May 18 11:01:37 2024 +0000

    Merge branch 'production'

commit 20987f2
Author: semantic-release-bot <semantic-release-bot@martynus.net>
Date:   Sat May 18 11:01:22 2024 +0000

    chore(release): 7.0.1

    ## [7.0.1](cotes2020/jekyll-theme-chirpy@v7.0.0...v7.0.1) (2024-05-18)

    ### Bug Fixes

    * **analytics:** goatcounter pv greater than 1K cannot be converted to numbers ([cotes2020#1762](cotes2020#1762)) ([33a1fa7](cotes2020@33a1fa7))
    * audio/video path apply variable `media_subpath` ([cotes2020#1745](cotes2020#1745)) ([00a27a1](cotes2020@00a27a1))

commit 39e4338
Merge: e33547f 33a1fa7
Author: Cotes Chung <11371340+cotes2020@users.noreply.github.com>
Date:   Sat May 18 18:58:08 2024 +0800

    Merge branch 'hotfix/7.0.1' into production

commit 33a1fa7
Author: Cotes Chung <11371340+cotes2020@users.noreply.github.com>
Date:   Sat May 18 18:52:45 2024 +0800

    fix(analytics): goatcounter pv greater than 1K cannot be converted to numbers (cotes2020#1762)

    The goatcounter PV report splits numbers with spaces, e.g. 1024 would be '1 024'

commit 00a27a1
Author: Alexander Fuks <kungfux@users.noreply.github.com>
Date:   Sat May 18 14:47:12 2024 +0400

    fix: audio/video path apply variable `media_subpath` (cotes2020#1745)

commit ab09f3b
Author: Steve Hoang <82992510+lotusk08@users.noreply.github.com>
Date:   Sat May 18 16:55:28 2024 +0700

    Update lib

commit a824184
Author: Steve Hoang <82992510+lotusk08@users.noreply.github.com>
Date:   Sat May 18 16:46:45 2024 +0700

    Update lib

commit 14c6cbc
Author: Steve Hoang <82992510+lotusk08@users.noreply.github.com>
Date:   Sat May 18 16:37:12 2024 +0700

    Update .gitmodules

commit 9e18b1c
Author: Steve Hoang <82992510+lotusk08@users.noreply.github.com>
Date:   Sat May 18 16:08:36 2024 +0700

    Update ci.yml

commit 5cdde7d
Author: Cotes Chung <11371340+cotes2020@users.noreply.github.com>
Date:   Fri May 17 20:11:08 2024 +0800

    ci: enable ci/style-lint for the `hotfix` branches

commit c4b58e3
Author: Cotes Chung <11371340+cotes2020@users.noreply.github.com>
Date:   Fri May 17 00:03:53 2024 +0800

    build: upgrade dependencies

    Updates `@fortawesome/fontawesome-free` to 6.5.2
    - [Release notes](https://github.com/FortAwesome/Font-Awesome/releases)
    - [Changelog](https://github.com/FortAwesome/Font-Awesome/blob/6.x/CHANGELOG.md)
    - [Commits](FortAwesome/Font-Awesome@6.5.1...6.5.2)

    Updates `dayjs` to 1.11.11
    - [Release notes](https://github.com/iamkun/dayjs/releases)
    - [Changelog](https://github.com/iamkun/dayjs/blob/dev/CHANGELOG.md)
    - [Commits](iamkun/dayjs@v1.11.10...v1.11.11)

    Updates `mermaid` to 10.9.0
    - [Release notes](https://github.com/mermaid-js/mermaid/releases)
    - [Changelog](https://github.com/mermaid-js/mermaid/blob/develop/CHANGELOG.md)
    - [Commits](mermaid-js/mermaid@v10.8.0...v10.9.0)

    Updates `tocbot` to 4.27.20
    - [Release notes](https://github.com/tscanlin/tocbot/releases)
    - [Changelog](https://github.com/tscanlin/tocbot/blob/master/CHANGELOG.md)
    - [Commits](tscanlin/tocbot@v4.25.0...v4.27.20)

commit 9630fd6
Author: Cotes Chung <11371340+cotes2020@users.noreply.github.com>
Date:   Sun May 12 07:35:58 2024 +0800

    ci(release): pass secrets to called workflow
kimbob13 pushed a commit to kimbob13/kimbob13.github.io that referenced this pull request May 25, 2024
@kungfux @kimbob13
fix: audio/video path apply variable media_subpath (cotes2020#1745)
37ecf50
gudtldn pushed a commit to gudtldn/gudtldn.github.io that referenced this pull request Jul 26, 2024
@kungfux @gudtldn
fix: audio/video path apply variable media_subpath (cotes2020#1745)
c7b021d
gudtldn pushed a commit to gudtldn/gudtldn.github.io that referenced this pull request Jul 26, 2024
@semantic-release-bot @gudtldn
chore(release): 7.0.1
92b26dd 
## [7.0.1](cotes2020/jekyll-theme-chirpy@v7.0.0...v7.0.1) (2024-05-18)

### Bug Fixes

* **analytics:** goatcounter pv greater than 1K cannot be converted to numbers ([cotes2020#1762](cotes2020#1762)) ([33a1fa7](cotes2020@33a1fa7))
* audio/video path apply variable `media_subpath` ([cotes2020#1745](cotes2020#1745)) ([00a27a1](cotes2020@00a27a1))
@github-actions GitHub Actions
Copy link

🎉 This issue has been resolved in version 7.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

ryo-wijaya pushed a commit to ryo-wijaya/blog that referenced this pull request Sep 9, 2024
@semantic-release-bot
chore(release): 7.0.1
213d4d1 
## [7.0.1](cotes2020/jekyll-theme-chirpy@v7.0.0...v7.0.1) (2024-05-18)

### Bug Fixes

* **analytics:** goatcounter pv greater than 1K cannot be converted to numbers ([#1762](cotes2020/jekyll-theme-chirpy#1762)) ([46d8b71](cotes2020/jekyll-theme-chirpy@46d8b71))
* audio/video path apply variable `media_subpath` ([#1745](cotes2020/jekyll-theme-chirpy#1745)) ([61cdc6a](cotes2020/jekyll-theme-chirpy@61cdc6a))
thejae-u pushed a commit to thejae-u/thejae-u.github.io that referenced this pull request Oct 16, 2024
@kungfux @thejae-u
fix: audio/video path apply variable media_subpath (cotes2020#1745)
b621318
thejae-u pushed a commit to thejae-u/thejae-u.github.io that referenced this pull request Oct 16, 2024
@semantic-release-bot @thejae-u
chore(release): 7.0.1
41e88bb 
## [7.0.1](cotes2020/jekyll-theme-chirpy@v7.0.0...v7.0.1) (2024-05-18)

### Bug Fixes

* **analytics:** goatcounter pv greater than 1K cannot be converted to numbers ([cotes2020#1762](cotes2020#1762)) ([33a1fa7](cotes2020@33a1fa7))
* audio/video path apply variable `media_subpath` ([cotes2020#1745](cotes2020#1745)) ([00a27a1](cotes2020@00a27a1))
damilola-oladele pushed a commit to damilola-oladele/damilola-oladele.github.io that referenced this pull request Nov 3, 2024
@semantic-release-bot @damilola-oladele
chore(release): 7.0.1
4e835ba 
## [7.0.1](cotes2020/jekyll-theme-chirpy@v7.0.0...v7.0.1) (2024-05-18)

### Bug Fixes

* **analytics:** goatcounter pv greater than 1K cannot be converted to numbers ([#1762](cotes2020/jekyll-theme-chirpy#1762)) ([33a1fa7](cotes2020/jekyll-theme-chirpy@33a1fa7))
* audio/video path apply variable `media_subpath` ([#1745](cotes2020/jekyll-theme-chirpy#1745)) ([00a27a1](cotes2020/jekyll-theme-chirpy@00a27a1))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cotes2020 cotes2020 cotes2020 approved these changes

@MrMurdock11 MrMurdock11 Awaiting requested review from MrMurdock11

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Embedded video does not respect the media_subpath Front Matter variable
3 participants
@kungfux @cotes2020 @semantic-release-bot