Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds webrick to Gemfile for Ruby 3.0 #247

Closed
wants to merge 2 commits into from
Closed

Adds webrick to Gemfile for Ruby 3.0 #247

wants to merge 2 commits into from

Conversation

mattpopovich
Copy link
Contributor

Description

Adds webrick to Gemfile for compatibility with Ruby 3.0 as mentioned in #245.
Also fixes small typo in PR template.

e.g. Fixes #(issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How has this been tested

  • I have run bash ./tools/test.sh --build (at the root of the project) locally and passed
  • I have tested this feature in the browser

Test Configuration

  • Browerser type & version: Chrome 87.0
  • Operating system: macOS 10.15.6
  • Bundler version: 2.2.4
  • Ruby version: 3.0.0p0
  • Jekyll version: 4.2.0

Checklist

  • My code follows the Google style guidelines
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

@mattpopovich mattpopovich mentioned this pull request Jan 12, 2021
Closed
3 tasks
@mattpopovich
Copy link
Contributor Author

Up to you if you want to accept it as it changes a few dependencies in Gemfile.lock
I imagine eventually jekyll will be updated so that webrick doesn't have to be manually included? Making this redundant? (jekyll/jekyll#8524)

cotes2020
cotes2020 requested changes Jan 12, 2021
View reviewed changes
Copy link
Owner

@cotes2020 cotes2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR template typo fixing and the regular dependencies version upgrade is OK. But we should leave webrick to Jekyll

Gemfile
Comment on lines +27 to +28

gem "webrick", "~> 1.7"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jekyll:master has fixed webrick dependency on Ruby 3.0, so we don't need to add any more

Gemfile.lock
@@ -92,6 +92,7 @@ GEM
tzinfo (>= 1.0.0)
unicode-display_width (1.7.0)
wdm (0.1.1)
webrick (1.7.0)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert the webrick statement

Gemfile.lock Show resolved Hide resolved
@cotes2020 cotes2020 closed this Jan 17, 2021
@mattpopovich mattpopovich deleted the cotes2020-ruby3_fix branch April 12, 2021 03:05
cotes2020 added a commit that referenced this pull request Jun 23, 2021
@cotes2020
Lock the ruby version number (#245, #247, #344)
8173831 
Since version 3.0, Ruby has no `webrick` that Jekyll (<= 4.2) needs
cotes2020 added a commit that referenced this pull request Jun 23, 2021
@cotes2020
Lock the ruby version number (#245, #247, #344)
d7b12b4 
Since version 3.0, Ruby has no `webrick` that Jekyll (<= 4.2) needs
cotes2020 added a commit that referenced this pull request Oct 22, 2021
@cotes2020
Lock the ruby version number (#245, #247, #344)
885ed44 
Since version 3.0, Ruby has no `webrick` that Jekyll (<= 4.2) needs
linkliu pushed a commit to linkliu/game-tech-post-old that referenced this pull request Dec 10, 2021
@cotes2020 @linkliu
Lock the ruby version number (cotes2020#245, cotes2020#247, cotes2020…
968f0cd 
…#344)

Since version 3.0, Ruby has no `webrick` that Jekyll (<= 4.2) needs

(cherry picked from commit 885ed44)
ambersun1234 pushed a commit to ambersun1234/chirpy.ambersun1234.github.io that referenced this pull request Feb 10, 2023
@cotes2020
Lock the ruby version number (cotes2020#245, cotes2020#247, cotes2020…
f066e90 
…#344)

Since version 3.0, Ruby has no `webrick` that Jekyll (<= 4.2) needs
Ap3x pushed a commit to Ap3x/ap3x.github.com that referenced this pull request Feb 23, 2023
@cotes2020
Lock the ruby version number (cotes2020#245, cotes2020#247, cotes2020…
58d1aa6 
…#344)

Since version 3.0, Ruby has no `webrick` that Jekyll (<= 4.2) needs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cotes2020 cotes2020 cotes2020 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattpopovich @cotes2020