Skip to content

Finalize transaction_get_result API #597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 18, 2024
Merged

Finalize transaction_get_result API #597

merged 1 commit into from
Jun 18, 2024

Conversation

DemetrisChr
Copy link
Contributor

@DemetrisChr DemetrisChr commented Jun 18, 2024 •
edited
Loading

  • Remove content() overloads that are not in spec.
  • Rename content to content_as
  • Rename key() to id()
  • Make bucket/scope/collection accessors private

@DemetrisChr DemetrisChr requested a review from avsej June 18, 2024 18:31
@avsej avsej force-pushed the txns-get-result branch from 3e796c6 to 4fd615e Compare June 18, 2024 21:28
@avsej avsej force-pushed the txns-get-result branch from 4fd615e to e95f812 Compare June 18, 2024 22:10
@avsej avsej force-pushed the txns-get-result branch from e95f812 to 0e48482 Compare June 18, 2024 22:50
@avsej avsej merged commit 47644b6 into couchbase:main Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avsej avsej avsej approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DemetrisChr @avsej