Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CBLDatabaseUpgrade selects wrong noAtts column #1025

Closed
pasin opened this issue Jan 8, 2016 · 0 comments
Closed

CBLDatabaseUpgrade selects wrong noAtts column #1025

pasin opened this issue Jan 8, 2016 · 0 comments
Labels
bug review
Milestone
1.2

Comments

@pasin
Copy link
Contributor

pasin commented Jan 8, 2016

From @borrrden via Skype :

I think this is a mistake -> https://github.com/couchbase/couchbase-lite-ios/blob/release/1.2/Source/CBLDatabaseUpgrade.m#L268

Should be column 6, not column 4 right?
@pasin pasin changed the title CBLDatabaseUpgrade selects wrong noAtts columns CBLDatabaseUpgrade selects wrong noAtts column Jan 8, 2016
@pasin pasin added this to the 1.2 milestone Jan 8, 2016
@pasin pasin added in progress and removed ready labels Jan 14, 2016
pasin added a commit that referenced this issue Jan 14, 2016
@pasin
Fixed selecting wrong noAtts column index in CBLDatabaseUpgrade
20ec2bd 
noAtts column index is 6 no 4.

#1025
@pasin pasin mentioned this issue Jan 14, 2016
Merged
@pasin pasin added review and removed in progress labels Jan 14, 2016
snej added a commit that referenced this issue Jan 18, 2016
@snej
Merge pull request #1037 from couchbase/feature/upgradedb_noatts
3a4cf64 
Fixed #1025 : selecting wrong noAtts column index in CBLDatabaseUpgrade
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug review
Projects
None yet
Milestone
1.2
Development

No branches or pull requests
2 participants
@zgramana @pasin