stream output should be gotten before writers are disposed

[smitcham]

I've checked my local commits to ensure that they have the right email on the commit.

[cb-sdk-robot]

Thanks for the pull request!! To ensure quality review, Couchbase employs a code review system based on Gerrit to manage the workflow of changes in addition to tracking our contributor agreements.

To get this change in and collaborate in code review, please register on Gerrit and accept our CLA. The easiest way to do this is to follow the link below, sign in with your GitHub account and then follow through the steps provided on that page to sign an 'Individual' agreement: http://review.couchbase.org/#/settings/new-agreement.

Keep in mind that the emails we are seeing on the commits are: sm****am@gma***com

Note: Please contact us if you have any issues registering with Gerrit! If you have not signed our CLA within 7 days, the Pull Request will be automatically closed.

::SDKBOT/PR:no_cla

[smitcham]

looks like it has the right email this time.

[cb-sdk-robot]

Thanks for the pull request!! To ensure quality review, Couchbase employs a code review system based on Gerrit to manage the workflow of changes in addition to tracking our contributor agreements.

To get this change in and collaborate in code review, please register on Gerrit and accept our CLA. The easiest way to do this is to follow the link below, sign in with your GitHub account and then follow through the steps provided on that page to sign an 'Individual' agreement: http://review.couchbase.org/#/settings/new-agreement.

Keep in mind that the emails we are seeing on the commits are: sm****am@gma***com

Note: Please contact us if you have any issues registering with Gerrit! If you have not signed our CLA within 7 days, the Pull Request will be automatically closed.

::SDKBOT/PR:no_cla

[jeffrymorris]

@smitcham - yeah, email looks right, but I don't see the commit yet in Gerrit. Try doing this:

1. Login to Gerrit
2. Click your Avatar on the upper right and then "Settings"
3. Select "Email Addresses" on the menu to your left and then add a new email (that matches sm****am@gma***com) using the "New Email Address" Textbox and click "Save"

Once you do this in Gerrit, it should come through.

-Jeff

[smitcham]

updated. commenting to see if that triggers things.

[cb-sdk-robot]

Your changes (commit: e69f409) have been pushed to the Couchbase Review Site:
http://review.couchbase.org/132532

::SDKBOT/PR:created

[smitcham]

review was created but isn't pointing to release27

[brantburnett]

@smitcham Can I recommend one tweak to this? One of the advantages of disposing the StreamWriter before calling ToArray is that ensures that the writer and encoder are fully flushed to the stream: https://github.com/dotnet/runtime/blob/master/src/libraries/System.Private.CoreLib/src/System/IO/StreamWriter.cs#L190. Instead of calling ToArray() before disposing, I'd recommend using the constructor overload on StreamWriter to pass leaveOpen as true. This way the dispose won't also dispose the underlying Stream, but the flush still occurs.

[jeffrymorris]

@smitcham - SDKBOT pushes to the master branch on Gerrit by default. I pushed to release27 and abandoned the commit on master. Since your now setup on Gerrit, I suggest you just push to Gerrit directly from now on - just add Gerrit as a remote (git remote add gerrit ssh://[your username]@review.couchbase.org:29418/couchbase-net-client.git . Note on Gerrit, the workflow is:

1. git add .
2. git commit --amend
3. git push gerrit HEAD:refs/for/release27

@brantburnett can you add your comment ^ to the review on gerrit?

[cb-sdk-robot]

This Pull Request has been closed as the associated Gerrit change was abandoned.

::SDKBOT/PR:abandoned