Skip to content

Conversation

emilienbev
Copy link
Collaborator

WIP, I need to check other pages to see what I can replace

}
----

WARNING: Helper methods `WithNamedParameter` and `WithPositionalParameter` take 1 parameter, and add it to the existing collection in the options. The methods `WithNamedParameters` and `WithPositionalParameters` take a collection of parameters and replace all existing.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something not quite right here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's subtle but the plural of the "With[...]Parameters" are additional overloads that replace the existing internal collection, instead of adding to it

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aha, too subtle for me :D
I'll need another coffee before I edit anything else today. :)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So,
"replace all existing"

Should that be
"replace all the parameters in the existing collection." - just to avoid ambiguity?

Copy link
Collaborator

@RichardSmedley RichardSmedley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci @emilienbev - LGTM 👍

@RichardSmedley RichardSmedley merged commit 3b65dac into couchbase:release/1.0 Oct 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants