Use Facebook ID instead of email to register users #580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch Facebook-based user creation to set name=ID instead of name=email, to support continued authentication of users who change their Facebook email. For backwards compatibility with users created prior to this change, the Facebook auth flow still tries to get a user based on email when it can't find one using ID. Changed RegisterNewUser into an authenticator method instead of a handler method for easier testability.
|
Any chance you could retest TodoLite-Android or ios against this version to make sure its still working? Let me know how I can help. |
|
@ajres after this PR is closed, can you hold off on refreshing the demo cluster sync gateway until these tickets are closed?
|
adamcfraser
added a commit
that referenced
this pull request
Jan 22, 2015
Use Facebook ID instead of email to register users
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #493
Switch Facebook-based user creation to set name=ID instead of name=email, to support continued authentication of users who change their Facebook email.
For backwards compatibility with users created prior to this change, the Facebook auth flow still tries to get a user based on email when it can't find one using ID.
Changed RegisterNewUser into an authenticator method instead of a handler method for easier testability.