CBG-4134: link rev cache memory limit config option to rev cache #7084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbrks
requested changes
Sep 3, 2024
| @@ -246,8 +246,9 @@ type DeprecatedCacheConfig struct { | |||
| } | |||
|
|
|||
| type RevCacheConfig struct { | |||
| Size *uint32 `json:"size,omitempty"` // Maximum number of revisions to store in the revision cache | |||
There was a problem hiding this comment.
We can't remove config options like this, it would be a breaking change for customers with existing configuration.
If we want to keep the size JSON field name, and rename the internal struct field to MaxItemCount to better represent the behaviour in the codebase, we can do that. The alternatve would be adding a new property, deprecating Size but still allowing it as a fallback.
Both of these options come with downsides.
rest/config.go
Outdated
Comment on lines
249
to
250
| MaxItemCount *uint32 `json:"max_item_count,omitempty"` // Maximum number of revisions to store in the revision cache | ||
| MaxMemoryCountMB *uint32 `json:"max_memory_count_mb"` // Maximum amount of memory the rev cache should consume in MB |
There was a problem hiding this comment.
What's the behaviour when both of these are set? The lower of the two?
There was a problem hiding this comment.
Correct, both will work in tandem with one another when memory limit is set. I have added a comment to MaxMemoryCountMB to reflect this info, let me know if it needs work.
Redocly previews |
Signed-off-by: Gregory Newman-Smith <gregory.newmansmith@couchbase.com>
bbrks
approved these changes
Sep 6, 2024
bbrks
pushed a commit
that referenced
this pull request
Sep 26, 2024
* CBG-4134: link rev cache memory limit config option to rev cache * failing tests * address commnets * fix yaml lint * fix failing test + mistake in docs Signed-off-by: Gregory Newman-Smith <gregory.newmansmith@couchbase.com> --------- Signed-off-by: Gregory Newman-Smith <gregory.newmansmith@couchbase.com>
1 task
gregns1
added a commit
that referenced
this pull request
Sep 27, 2024
* CBG-4023: Removal unmarshalled body on the rev cache (#7030) * CBG-4135: new stat for rev cache capacity (#7049) * CBG-4135: new stat for rev cache capacity * updated based on review * fix linter * lint again * CBG-4032: memory based rev cache implementation (#7040) * CBG-4032: memory based rev cache implementation * make test pass with default collection + missing return param * more issues with default collection test * touch ups on comment + remove unused function * updated for review * further tidy up * lint fix after refector test * fixes from rebase * updates based off review + some more refactoring * CBG-4134: link rev cache memory limit config option to rev cache (#7084) * CBG-4134: link rev cache memory limit config option to rev cache * failing tests * address commnets * fix yaml lint * fix failing test + mistake in docs Signed-off-by: Gregory Newman-Smith <gregory.newmansmith@couchbase.com> --------- Signed-off-by: Gregory Newman-Smith <gregory.newmansmith@couchbase.com> * CBG-4234: clean up rev cache work (#7113) * CBG-4234: clean up rev cache work * new test * CBG-4277: Remove unused totalBytesForHistory from getHistory (#7137) --------- Signed-off-by: Gregory Newman-Smith <gregory.newmansmith@couchbase.com> Co-authored-by: Gregory Newman-Smith <109068393+gregns1@users.noreply.github.com>
bbrks
added a commit
that referenced
this pull request
Oct 8, 2024
* CBG-4023: Removal unmarshalled body on the rev cache (#7030) * CBG-4135: new stat for rev cache capacity (#7049) * CBG-4135: new stat for rev cache capacity * updated based on review * fix linter * lint again * CBG-4032: memory based rev cache implementation (#7040) * CBG-4032: memory based rev cache implementation * make test pass with default collection + missing return param * more issues with default collection test * touch ups on comment + remove unused function * updated for review * further tidy up * lint fix after refector test * fixes from rebase * updates based off review + some more refactoring * CBG-4134: link rev cache memory limit config option to rev cache (#7084) * CBG-4134: link rev cache memory limit config option to rev cache * failing tests * address commnets * fix yaml lint * fix failing test + mistake in docs Signed-off-by: Gregory Newman-Smith <gregory.newmansmith@couchbase.com> --------- Signed-off-by: Gregory Newman-Smith <gregory.newmansmith@couchbase.com> * CBG-4234: clean up rev cache work (#7113) * CBG-4234: clean up rev cache work * new test * CBG-4277: Remove unused totalBytesForHistory from getHistory (#7137) --------- Signed-off-by: Gregory Newman-Smith <gregory.newmansmith@couchbase.com> Co-authored-by: Gregory Newman-Smith <109068393+gregns1@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CBG-4134
Pre-review checklist
fmt.Print,log.Print, ...)base.UD(docID),base.MD(dbName))docs/apiDependencies (if applicable)
Integration Tests
GSI=true,xattrs=truehttps://jenkins.sgwdev.com/job/SyncGateway-Integration/2673/