-
Notifications
You must be signed in to change notification settings - Fork 30
Vale test suite #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Vale test suite #40
Changes from all commits
Commits
Show all changes
48 commits
Select commit
Hold shift + click to select a range
ece1a78
Sketch of Vale test
osfameron f596a82
tweak expected results
osfameron d4037e8
Style Tests
osfameron f54f47f
Some more tests (and driveby fixes for review)
osfameron 37a1486
Stub tests for all Couchbase styles
osfameron a51923e
Split the .adoc file into YAML declarations
osfameron 2eaa7ab
Fixed tests for this style
osfameron 7e6b290
intermediate datastructure
osfameron 6feeb4b
reinstate tests
osfameron cfa23bc
remove debugging
osfameron ae70f05
highlight.js + test
osfameron 529dedb
remove commented code
osfameron 603d747
Highlight the style infractions
osfameron 5200905
better VentilatedProse test.
osfameron 28f3b0d
Updated format of output
osfameron 302a4c7
Tweak repeated space test
osfameron 4ac17f5
more style tweaks
osfameron cf7c30e
delete RepeatedWord test and update html
osfameron d44c17b
Update tests and HTML
osfameron 3e284c1
diagnostics
osfameron 27e77dd
install vale
osfameron bbeb9e1
add .vale.ini
osfameron 40f6ea6
reset to all used in actual config
osfameron e597f6a
diagnostics
osfameron 102bcbf
diagnostics
osfameron f63c352
working-directory
osfameron 3c1c322
readdir diagnostics
osfameron 7207095
more diag
osfameron 901d7ba
toString
osfameron b63fc9f
more diagnostics
osfameron 4795a30
more diagnostics
osfameron dfefb68
more diag
osfameron 983ce62
Fixed UnexplainedAcronym rule
osfameron 3e84afc
diagnostics
osfameron 484bfa1
explicit config location
osfameron 7917d60
no-global ?
osfameron 459f6bc
VALE_STYLES_PATH
osfameron 3b2d0bf
fix
osfameron 3d04073
fix
osfameron 573295c
tweak
osfameron 7779d4a
experiment hardcode single fixture
osfameron 479eeb2
use Github Actions $RUNNER_TEMP variable
osfameron 4cd7b7d
revert tweaks
osfameron 80b722d
explain workaround, back out diagnostics.
osfameron c121f6d
remove final diagnostics
osfameron c265aa2
upload styles.html as artifact
osfameron 6b73cb8
Update PR against main
osfameron c748535
Removing contradictory 'we are' contraction from Contractions.yml. Fi…
sarahlwelton File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
**/*.actual |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
StylesPath = "." | ||
MinAlertLevel = suggestion | ||
|
||
Vocab = Couchbase | ||
|
||
[asciidoctor] | ||
description = YES | ||
docname = YES | ||
doctitle = YES | ||
doctype = YES | ||
docfile = YES | ||
example-caption = YES | ||
figure-caption = YES | ||
important-caption = YES | ||
listing-caption = YES | ||
note-caption = YES | ||
outfile = YES | ||
part-signifier = YES | ||
preface-title = YES | ||
table-caption = YES | ||
tip-caption = YES | ||
toc-title = YES | ||
warning-caption = YES | ||
|
||
experimental = YES | ||
|
||
attribute-missing = drop | ||
|
||
[*.{adoc,md,txt}] | ||
BasedOnStyles = Vale, write-good, proselint, Couchbase, Google | ||
|
||
Vale.Spelling = NO |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,5 +5,6 @@ level: error | |
tokens: | ||
- dropdown | ||
- drop down | ||
- drop-down | ||
- dropdowns | ||
- drop downs | ||
- drop downs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,10 @@ | ||
extends: existence | ||
message: Don't use italics. Find another way to add emphasis. | ||
level: error | ||
link: https://docs.couchbase.com/styleguide/italic.html | ||
scope: | ||
- raw | ||
scope: raw | ||
nonword: true | ||
level: error | ||
|
||
tokens: | ||
- '(?<!`)\b_\w.*?_\b(?!`)' | ||
- '\|\s*_(.*?)_' | ||
- '\|\s*_(.*?)_' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did we comment out the
scope
setting?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, driveby hack hack hack hack...
and it seems not to be necessary? (At least according to the minimal test cases)
Happy to revert, but we might as well make it part of the test: can you provide a counterexample that it's needed for?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it works without it, don't worry about it - was just curious.
I can't find the documentation around the
text
scope now to figure out what it's supposed to limit.