allow setting stage to false for transform steps that dont use input or output nodes #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or output nodes Conflicts: dataduct/steps/load_reload_pk.py
|
@sb2nov do you know why we set It seems |
| self.get_output_s3_path(get_modified_s3_path(output_path))) | ||
| # Create output_node based on output_path | ||
| base_output_node = self.create_s3_data_node( | ||
| self.get_output_s3_path(get_modified_s3_path(output_path))) |
There was a problem hiding this comment.
why remove the if as it will create a useless S3Node, doesn't make an actual difference
|
If we used self_output it will create multiple staging directories instead what we want is a single staging directory that gets mapped to multiple nodes based on subdirectories so that the command doesn't need to figure out which staging directory maps to what output and is easier to manage. |
|
Let me know if you want more details on it. |
|
LGTM though |
cliu587
added a commit
that referenced
this pull request
Nov 18, 2015
…output allow setting stage to false for transform steps that dont use input or output nodes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PTAL @sb2nov, @darinyu-coursera. Will land after the new load_reload_pk step is tested and with this diph.