Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove react-modal afterClose bug workaround #1234

Merged
merged 4 commits into from
Aug 23, 2019

Conversation

gdostie
Copy link
Collaborator

@gdostie gdostie commented Aug 22, 2019

Proposed Changes

Now that the afterClose prop bug has been closed (see reactjs/react-modal#755) we can safely remove the workaround we made in the ModalComposite component.

Potential Breaking Changes

Hopefully none.

Acceptance Criteria

  • The proposed changes are covered by unit tests
  • The potential breaking changes are clearly identified
  • README.md is adjusted to reflect the proposed changes (if relevant)

@gdostie gdostie requested a review from a team as a code owner August 22, 2019 15:49
Copy link

@coveobot coveobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codecov-io
Copy link

codecov-io commented Aug 22, 2019

Codecov Report

Merging #1234 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1234      +/-   ##
==========================================
- Coverage   99.66%   99.66%   -0.01%     
==========================================
  Files         354      354              
  Lines        8926     8917       -9     
  Branches     2112     2111       -1     
==========================================
- Hits         8896     8887       -9     
  Misses         30       30
Impacted Files Coverage Δ
...eact-vapor/src/components/modal/ModalComposite.tsx 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c216efd...142dd17. Read the comment docs.

@gdostie gdostie merged commit 82a681a into master Aug 23, 2019
@gdostie gdostie deleted the remove-react-modal-afterClose-workaround branch August 23, 2019 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants