-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update to TypeScript 5, Stencil 4 (and more ) #3162
Conversation
Pull Request Report PR Title ✅ Title follows the conventional commit spec. Bundle Size
|
Dependency ReviewThe following issues were found:
Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. License Issuespackage-lock.json
utils/atomic-storybook/package-lock.json
utils/atomic-storybook/package.json
Allowed Licenses: 0BSD, Apache-2.0, Apache-2.0 AND MIT, Apache-2.0 AND BSD-3-Clause AND Python-2.0, Beerware, BlueOak-1.0.0, BSD-1-Clause, BSD-2-Clause, BSD-2-Clause-Patent, BSD-2-Clause-Views, BSD-2-Clause AND MIT, BSD-3-Clause, BSD-3-Clause-Attribution, BSD-3-Clause-Clear, BSL-1.0, CC-BY-3.0, CC-BY-4.0, CC0-1.0, CNRI-Python, curl, HPND, IBM-pibs, ImageMagick, ISC, JSON, MIT, MIT-0, MIT AND ISC, MIT AND Python-2.0, MIT-advertising, mpi-permissive, NCSA, ODC-By-1.0, PDDL-1.0, Plexus, PostgreSQL, PSF-2.0, Python-2.0, Python-2.0.1, SAX-PD, Unlicense, UPL-1.0, W3C, Wsuipa, WTFPL, X11, X11-distribute-modifications-variant, Xerox, Zlib, ZPL-2.1 Scanned Manifest Filespackage-lock.json
package.json
packages/atomic-angular/package.json
packages/atomic-hosted-page/package.json
packages/atomic/package.json
packages/auth/package.json
packages/bueno/package.json
packages/headless/package.json
packages/quantic/package.json
packages/samples/angular/package.json
packages/samples/atomic-next/package.json
packages/samples/atomic-react/package.json
packages/samples/headless-react/package.json
packages/samples/stencil/package.json
packages/samples/vuejs/package.json
utils/atomic-storybook/package-lock.json
utils/atomic-storybook/package.json
utils/nx-plugin/package.json
utils/release/package.json
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes!
.../atomic/src/components/search/result-template-components/result-template-decorators.spec.tsx
Outdated
Show resolved
Hide resolved
utils/atomic-storybook/.storybook/code-sample-addon/code-sample-panel.jsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of questions, but this looks good 🙂
.../atomic/src/components/search/result-template-components/result-template-decorators.spec.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's nice !
.../atomic/src/components/search/result-template-components/result-template-decorators.spec.tsx
Outdated
Show resolved
Hide resolved
utils/atomic-storybook/.storybook/code-sample-addon/code-sample-panel.jsx
Show resolved
Hide resolved
Everything seems 💯 🚢 |
Verified:
|
ionic-team/stencil#3831 (comment) There might be some side-effects with the patch, waiting for confirmation tho: our tests seems to pass, so I want to see what would break |
After discussion with both stencil maintainer & the team, we decided to go ahead with the patch/custom behavior and introduce a caveat: 8b5aa97 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Mostly upgrade Stencil to v4 and TypeScript to v5.
Bonuses:
The riskiest/biggest change is around the patch in the Stencil compiler (good old AST ) See:
Will scope out the type fix of the code-editor component of Storybook into an improvement: Unknown amount of effort, very low reward.
https://coveord.atlassian.net/browse/KIT-2312