Bump sdk version, update tests #771
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Uh seem not supported on Mac, it's a pity. |
Do you want to help make this work? I'll help figure out how to implement it. I don't have a mac myself. |
Eh the problem is that I don't have Mac too...I work on win and WSL 😞. |
|
Damn you, Mac! I've created an issue for it: tmds/Tmds.ExecFunction#6. Maybe we can find someone willing, and able. |
|
Ok for now I'll skip these test on Mac, historically I never seen any difference for these tests between three plat. Win/Linux should be enough |
MarcoRossignoli
changed the title
MarcoRossignoli
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3.1.*