Trigger npm publish when a release/pre-release is created #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramirotw
commented
Jul 21, 2022
| git tag -m "Version $version" --end-of-options "$version_tag" | ||
|
|
||
| git push origin "refs/tags/$version_tag" | ||
|
|
There was a problem hiding this comment.
tags must be created through the Releases UI
ESLint Summary View Full Report
Report generated by eslint-plus-action |
alfetopito
reviewed
Jul 21, 2022
There was a problem hiding this comment.
Wow, is that all there's to it?
That's extremely simple.
And we also talked about this internally last week.
The only concern that I have with this now is that what can happen is the package.json version not match the release's version.
Left a comment below with a suggestion to address that
W3stside
approved these changes
Jul 22, 2022
ramirotw
force-pushed
the
ramirotw/publish
branch
from
c338af0
to
fba8c04
Compare
This was referenced Aug 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed, we should be publishing npm packages when creating new releases and not doing it manually to avoid losing sync between npm versions and releases as we have now with
1.0.0-RC.0