Ensure OSGi exports packages with versions

[ancoron]

Currently (released version 3.1.1) the OSGi exports doesn't come with any version information. Therefore the framework falls back to the default export version, which is "0.0.0".

This could introduce problems in several cases and is not recommended.

Output from a Felix Shell:

java-uuid-generator [372] exports packages:
-------------------------------------------
com.fasterxml.uuid; version=0.0.0 UNUSED
com.fasterxml.uuid.ext; version=0.0.0 UNUSED
com.fasterxml.uuid.impl; version=0.0.0 UNUSED

[cowtowncoder]

Ok. That is a bug, need to fix.

[cowtowncoder]

Hmmh. Maven-bundle-plugin is supposed to automatically add this information, but somehow it isn't. I don't know how to force this; must be missing something here....

[ancoron]

I don't know exactly, but it could be that something inside the oss-sonatype parent is preventing this.

Besides that it could also be the change from bnd 0.x to 1.x of the plugin which introduced the changes (defaults to the OSGi default export version by simply not setting them and letting the framework implementation decide). The same goes for (dynamic) imports.

I guess, here we face the "explicit is better than implicit" thing. :-)

However, to make really sure things work like they should I#ve modified the pom.xml a bit:

diff --git a/pom.xml b/pom.xml
index 3893443..1993112 100644
--- a/pom.xml
+++ b/pom.xml
@@ -42,6 +42,7 @@ JUG supports all 3 official UUID generation methods.
   </prerequisites>
   <properties>
     <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
+    <log4j.version>1.2.13</log4j.version>
   </properties>
   <licenses>
     <license>
@@ -61,7 +62,7 @@ JUG supports all 3 official UUID generation methods.
     <dependency> <!-- log4j is optional, but needed for compilation -->
       <groupId>log4j</groupId>
       <artifactId>log4j</artifactId>
-      <version>1.2.13</version>
+      <version>${log4j.version}</version>
       <scope>compile</scope>
     </dependency>
     <!-- and for testing, JUnit is needed -->
@@ -133,18 +134,20 @@ JUG supports all 3 official UUID generation methods.
               <Bundle-SymbolicName>${project.artifactId}</Bundle-SymbolicName>
               <Bundle-Description>${project.description}</Bundle-Description>
               <Bundle-Vendor>FasterXML.com</Bundle-Vendor>
+              <Export-Package>
+                com.fasterxml.uuid;version="${project.version}",
+                com.fasterxml.uuid.ext;version="${project.version}",
+                com.fasterxml.uuid.impl;version="${project.version}"
+              </Export-Package>
               <Import-Package>
-</Import-Package>
+                com.fasterxml.uuid;version="[${project.version},${project.version}]",
+                com.fasterxml.uuid.ext;version="[${project.version},${project.version}]",
+                com.fasterxml.uuid.impl;version="[${project.version},${project.version}]"
+              </Import-Package>
+              <Private-Package></Private-Package>
               <DynamicImport-Package>
-org.apache.log4j
-</DynamicImport-Package>
-              <Private-Package>
-</Private-Package>
-              <Export-Package>
-com.fasterxml.uuid
-,com.fasterxml.uuid.ext
-,com.fasterxml.uuid.impl
-</Export-Package>
+                org.apache.log4j;version="[${log4j.version},1.3)"
+              </DynamicImport-Package>
             </instructions>
           </configuration>
        </plugin>

[ancoron]

Sorry, hit the wrong button

[cowtowncoder]

Ok; if explicit inclusion is needed, so be it; it's still based on actual version so it's just bit more stuff but no less dynamic.

[ancoron]

Thanx :-)

[cowtowncoder]

Hmmh. I don't quite follow why import statements are also needed; but I'll trust your knowledge on it being necessary.
I will build 3.1.2, push it to Maven repos.