-
-
Notifications
You must be signed in to change notification settings - Fork 113
Fix #73: add Generators.defaultTimeBasedGenerator()
#72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #73: add Generators.defaultTimeBasedGenerator()
#72
Conversation
Pull from upstream
pull from upstream
pull from upstream
sync with upstream
EgressDiagnostics: correctly display mac address (cowtowncoder#58)
sync with upstream
merge from upstream
This reverts commit 041cb79
This reverts commit dded1a2
- hopefully this is a path to identifying the egress interface on MacOS
- moved to a separate class - on Mac OS, use a Socket rather than DatagramSocket
Ok thank you @pgalbraith. I hope to look into this soon (will be traveling upcoming week so it may take while). I noticed CI failed for some reason, if you can have a look? (seemed odd, wrt references to Javadocs, maybe transient issue) EDIT: Ok so there's just couple of unescaped HTML entities in Javadocs, like:
so if you can fix those it should pass (most lines are just warnings wrt "missing" Javadoc entries; feel free to ignore those, only errors matter) |
@cowtowncoder gotcha, yes easy fix, thanks! |
Generators.defaultTimeBasedGenerator()
Looks good; merged, will publish 4.2.0 next. |
@cowtowncoder it looks like that last test worked on Mac. I've refactored the egress finding code out to a separate class, please give this one a try.