Skip to content

Fix #73: add Generators.defaultTimeBasedGenerator() #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

pgalbraith
Copy link
Contributor

@cowtowncoder it looks like that last test worked on Mac. I've refactored the egress finding code out to a separate class, please give this one a try.

pgalbraith and others added 11 commits June 18, 2022 11:55
EgressDiagnostics: correctly display mac address (cowtowncoder#58)
- hopefully this is a path to identifying the egress interface on MacOS
- moved to a separate class
- on Mac OS, use a Socket rather than DatagramSocket
@cowtowncoder
Copy link
Owner

cowtowncoder commented May 7, 2023

Ok thank you @pgalbraith. I hope to look into this soon (will be traveling upcoming week so it may take while).

I noticed CI failed for some reason, if you can have a look? (seemed odd, wrt references to Javadocs, maybe transient issue)

EDIT: Ok so there's just couple of unescaped HTML entities in Javadocs, like:

error: bad HTML entity
Error:       * & Linux, and is faster to uses than {@link Socket} as opening one does

so if you can fix those it should pass (most lines are just warnings wrt "missing" Javadoc entries; feel free to ignore those, only errors matter)

@pgalbraith
Copy link
Contributor Author

Ok thank you @pgalbraith. I hope to look into this soon (will be traveling upcoming week so it may take while).

I noticed CI failed for some reason, if you can have a look? (seemed odd, wrt references to Javadocs, maybe transient issue)

EDIT: Ok so there's just couple of unescaped HTML entities in Javadocs, like:

error: bad HTML entity
Error:       * & Linux, and is faster to uses than {@link Socket} as opening one does

so if you can fix those it should pass (most lines are just warnings wrt "missing" Javadoc entries; feel free to ignore those, only errors matter)

@cowtowncoder gotcha, yes easy fix, thanks!

@cowtowncoder cowtowncoder changed the title Another attempt at egress interface determination Fix #73: add Generators.defaultTimeBasedGenerator() May 14, 2023
@cowtowncoder cowtowncoder merged commit 1037107 into cowtowncoder:master May 14, 2023
@cowtowncoder cowtowncoder added this to the 4.2.0 milestone May 14, 2023
@cowtowncoder
Copy link
Owner

Looks good; merged, will publish 4.2.0 next.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants