-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes bills matching #1440
Merged
Merged
Fixes bills matching #1440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Find out why our models parent class and Document from cozy-doctypes are differentcozy-banks/scripts/visualizer/src/server/index.js Lines 12 to 17 in d8fb0c3
This comment was generated by todo based on a
|
ptbrowne
approved these changes
Aug 2, 2019
This allows us to have single test case on each file instead of a moutain of cases in the middle of the spec file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had some cases in which our bills matching algorithm fails. This had the following causes:
io.cozy.bills
, thevendor
property sometimes matches our brand dictionary'sname
property, and sometimes thekonnectorSlug
property. So we now try to get the brand fromname
andkonnectorSlug
instead of justname
automaticCategoryId
andmanualCategoryId
. But we now havecozyCategoryId
andlocalCategoryId
. So we just use thegetCategoryId
helper that implements all that instead of the previously incompletegetCategoryId
I also refactored
Linker::linkBillsToOperations
tests so that it's easier to read and maintain. Each test case now lives inside its own file and is in a JS object format instead of text format that needs to be parsed and become less and less readable as we add new cases.