Skip to content

Conversation

vulder
Copy link
Member

@vulder vulder commented Jan 24, 2021

Changes skeleton meta-text description wording from instructions to description. This should make it clearer for people that the italics descriptions should be kept in every topic.

Changes skeleton meta-text description wording from instructions to description. This should make it clearer for people that the italics descriptions should be kept in every topic.
@vulder
Copy link
Member Author

vulder commented Jan 24, 2021

@cjdb @rwdougla What do you think. Is it enough to change the wording from instructions to descriptions, to make it clear that one should keep the italics text in the doc?

As an alternative, I can add explicit wording that mentions this, like:

..., so please don't remove these descriptions when editing the topic.

@vulder vulder requested a review from cjdb January 24, 2021 21:07
@vulder
Copy link
Member Author

vulder commented Mar 12, 2021

@rwdougla What are you thoughts about the wording?

@rwdougla
Copy link
Contributor

Impressively, I think the one word change does mitigate my concern. Your extended "alternative" is likely to save you from repeating this, though, and so probably has some value, too.

@vulder
Copy link
Member Author

vulder commented Mar 12, 2021

Impressively, I think the one word change does mitigate my concern. Your extended "alternative" is likely to save you from repeating this, though, and so probably has some value, too.

👍 It choose the long version and updated all topics. Could you review/approve this PR?

@vulder vulder requested a review from jcvw March 15, 2021 20:48
Copy link
Collaborator

@jcvw jcvw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good tom me.

@vulder vulder merged commit 9860154 into master Mar 15, 2021
@vulder vulder deleted the SkeletionMetaTextUpdate branch March 15, 2021 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants