Skip to content

P1959R0 Remove std::weak_equality and std::strong_equality #3475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 24, 2019
Merged

P1959R0 Remove std::weak_equality and std::strong_equality #3475

merged 2 commits into from
Nov 24, 2019

Conversation

burblebee
Copy link
Contributor

@burblebee burblebee commented Nov 16, 2019 •
edited by zygoloid
Loading

Fixes #3423.
Fixes cplusplus/nbballot#168.
Fixes cplusplus/nbballot#171.

Issues:

  • wrt my editorial commit "[temp.param] Reword types in bulleted list for consistency", the spec is inconsistent wrt "function pointer" v. "function pointer type" - which should be used?

JohelEGP
JohelEGP suggested changes Nov 16, 2019
View reviewed changes
@jensmaurer jensmaurer added this to the post-2019-11 milestone Nov 16, 2019
@jensmaurer jensmaurer changed the title Motions 2019 11 lwg 21: P1959R0 Remove std::weak_equality and std::strong_equality P1959R0 Remove std::weak_equality and std::strong_equality Nov 17, 2019
jensmaurer
jensmaurer requested changes Nov 17, 2019
View reviewed changes
Copy link
Member

@jensmaurer jensmaurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not seeing deletions corresponding to these two changes in the paper:

Remove 17.11.2.2 [cmp.weakeq] (the subclause that defines std::weak_equality).
Remove 17.11.2.3 [cmp.strongeq] (the subclause that defines std::strong_equality).

@jensmaurer jensmaurer added the changes requested Changes to the wording or approach have been requested and not yet applied. label Nov 17, 2019
@burblebee burblebee removed the changes requested Changes to the wording or approach have been requested and not yet applied. label Nov 19, 2019
@burblebee burblebee requested a review from jensmaurer November 19, 2019 20:57
@zygoloid zygoloid force-pushed the motions-2019-11-lwg-21 branch 2 times, most recently from d9ccd59 to 835ceea Compare November 24, 2019 04:28
@zygoloid zygoloid force-pushed the motions-2019-11-lwg-21 branch from 835ceea to ab483d4 Compare November 24, 2019 04:29
@zygoloid zygoloid merged commit cbd19c5 into master Nov 24, 2019
@frederick-vs-ja frederick-vs-ja mentioned this pull request Nov 26, 2019
Closed
@jensmaurer jensmaurer deleted the motions-2019-11-lwg-21 branch February 18, 2020 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zygoloid zygoloid zygoloid approved these changes

@jensmaurer jensmaurer Awaiting requested review from jensmaurer

+1 more reviewer

@JohelEGP JohelEGP JohelEGP requested changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
post-2019-11
4 participants
@burblebee @zygoloid @JohelEGP @jensmaurer