qualifies indirectly-readable-impl's use of iter_move #3532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, Chris. Please add the stable tag [iterator.concept.readable] to the start of your commit message (and re-push). |
…of iter_move The exposition-only concept _`indirectly-readable-impl`_ relies on `ranges::iter_move`, but the text was missing the `ranges::` qualifier. This commit adds it, as the intention is to use `ranges::iter_move`, not `std::iter_move`.
CaseyCarter
approved these changes
Dec 9, 2019
|
I find it incredibly ironic that the commit message doesn't say "...use of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The exposition-only concept
indirectly-readable-implrelies onranges::iter_move, but the text was missing theranges::qualifier.This commit adds it, as the intention is to use
ranges::iter_move, notstd::iter_move.cc @jwakely @CaseyCarter @ericniebler @timsong-cpp