CWG Poll 14: P1815R2 Translation-unit-local entities #3740
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burblebee
requested changes
Feb 23, 2020
| \item | ||
| a potentially-constant variable\iref{expr.const}, or | ||
| \item | ||
| a specialization of a templated class. |
There was a problem hiding this comment.
What is a "templated class"?
There was a problem hiding this comment.
A templated entity that is a class. (Any fixes in this area should be separate.)
There was a problem hiding this comment.
Please replace "templated class" editorially in a separate commit with: "templated entity that is a class type" (since at least "templated entity" is defined).
There was a problem hiding this comment.
Sorry, won't do. CWG is contemplating changing the definition to "An entity is templated if..." , which might even be an editorial fix.
burblebee
changed the title
zygoloid
force-pushed
the
motions-2020-02-cwg-14
branch
from
a025b4c to
4ac6427
Compare
Also fixes NB US 035, US 133, and US 134 (C++20 CD).
private-module-fragment are definition domains.
zygoloid
force-pushed
the
motions-2020-02-cwg-14
branch
from
4ac6427 to
887d0f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes NB US 035, US 133, and US 134 (C++20 CD).
Fixes #3698.
Fixes cplusplus/papers#586.
Fixes cplusplus/nbballot#34.
Fixes cplusplus/nbballot#132.
Fixes cplusplus/nbballot#133.